-
Notifications
You must be signed in to change notification settings - Fork 749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Bintray documentation to README and installation doc #785
Conversation
@cdrage, thank you for the pull request! We'll request some people to review your PR. @e-minguez, please review this. |
README.md
Outdated
|
||
```sh | ||
# Linux | ||
curl -L https://kompose.bintray.com/kompose/latest/:kompose-linux-amd64 -o kompose |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the link is not working :-( It returns file with just The requested path was not found.
This link should work https://dl.bintray.com/kedgeproject/kedge/latest/kedge-linux-amd64
README.md
Outdated
curl -L https://kompose.bintray.com/kompose/latest/:kompose-linux-amd64 -o kompose | ||
|
||
# macOS | ||
curl -L https://kompose.bintray.com/kompose/latest/:kompose-darwin-amd64 -o kompose |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
README.md
Outdated
|
||
__Windows:__ | ||
|
||
Download from [Bintray](https://kompose.bintray.com/kompose/latest/:kompose-windows-amd64.exe) and add the binary to your PATH. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docs/installation.md
Outdated
|
||
```sh | ||
# Linux | ||
curl -L https://kompose.bintray.com/kompose/latest/:kompose-linux-amd64 -o kompose |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docs/installation.md
Outdated
curl -L https://kompose.bintray.com/kompose/latest/:kompose-linux-amd64 -o kompose | ||
|
||
# macOS | ||
curl -L https://kompose.bintray.com/kompose/latest/:kompose-darwin-amd64 -o kompose |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
docs/installation.md
Outdated
|
||
__Windows:__ | ||
|
||
Download from [Bintray](https://kompose.bintray.com/kompose/latest/:kompose-windows-amd64.exe) and add the binary to your PATH. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kadel I used the links directly from bintray but they were wrong.. thanks for the review! Updated the PR. |
README.md
Outdated
|
||
```sh | ||
# Linux | ||
curl -L https://dl.bintray.com/kedgeproject/kedge/latest/kompose-linux-amd64 -o kompose |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
link is not working :(
https://dl.bintray.com/kedgeproject/kedge/latest/kompose-linux-amd64
looks weird
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, my bad :-D
kedgeproject/kedge
part is obviously wrong (my copy/paste error) :-(
kompose/kompose
is supposed be there.
correct link is: https://dl.bintray.com/kompose/kompose/latest/kompose-linux-amd64
README.md
Outdated
curl -L https://dl.bintray.com/kedgeproject/kedge/latest/kompose-linux-amd64 -o kompose | ||
|
||
# macOS | ||
curl -L https://dl.bintray.com/kedgeproject/kedge/latest/kompose-darwin-amd64 -o kompose |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
README.md
Outdated
|
||
__Windows:__ | ||
|
||
Download from [Bintray](https://dl.bintray.com/kedgeproject/kedge/latest/kompose-windows-amd64.exe) and add the binary to your PATH. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
error 404 for this link
docs/installation.md
Outdated
|
||
```sh | ||
# Linux | ||
curl -L https://dl.bintray.com/kedgeproject/kedge/latest/kompose-linux-amd64 -o kompose |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above
docs/installation.md
Outdated
curl -L https://dl.bintray.com/kedgeproject/kedge/latest/kompose-linux-amd64 -o kompose | ||
|
||
# macOS | ||
curl -L https://dl.bintray.com/kedgeproject/kedge/latest/kompose-darwin-amd64 -o kompose |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above
docs/installation.md
Outdated
|
||
__Windows:__ | ||
|
||
Download from [Bintray](https://dl.bintray.com/kedgeproject/kedge/latest/kompose-windows-amd64.exe) and add the binary to your PATH. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above
If I goto this link
|
you can find all the correct links here: https://dl.bintray.com/kompose/kompose/latest/ Sorry about confusion with Kedge :-( |
Adds information on nightly builds to the README and installation document.
I think this it the longest review for a doc every from mistypes, haha. Both @kadel and I had brainfarts. Updated (again!). |
Adds information on nightly builds to the README and installation
document.