Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bintray documentation to README and installation doc #785

Merged
merged 1 commit into from
Aug 25, 2017

Conversation

cdrage
Copy link
Member

@cdrage cdrage commented Aug 21, 2017

Adds information on nightly builds to the README and installation
document.

@kompose-bot
Copy link
Collaborator

@cdrage, thank you for the pull request! We'll request some people to review your PR. @e-minguez, please review this.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 21, 2017
README.md Outdated

```sh
# Linux
curl -L https://kompose.bintray.com/kompose/latest/:kompose-linux-amd64 -o kompose
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the link is not working :-( It returns file with just The requested path was not found.

This link should work https://dl.bintray.com/kedgeproject/kedge/latest/kedge-linux-amd64

README.md Outdated
curl -L https://kompose.bintray.com/kompose/latest/:kompose-linux-amd64 -o kompose

# macOS
curl -L https://kompose.bintray.com/kompose/latest/:kompose-darwin-amd64 -o kompose
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

README.md Outdated

__Windows:__

Download from [Bintray](https://kompose.bintray.com/kompose/latest/:kompose-windows-amd64.exe) and add the binary to your PATH.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


```sh
# Linux
curl -L https://kompose.bintray.com/kompose/latest/:kompose-linux-amd64 -o kompose
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

curl -L https://kompose.bintray.com/kompose/latest/:kompose-linux-amd64 -o kompose

# macOS
curl -L https://kompose.bintray.com/kompose/latest/:kompose-darwin-amd64 -o kompose
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


__Windows:__

Download from [Bintray](https://kompose.bintray.com/kompose/latest/:kompose-windows-amd64.exe) and add the binary to your PATH.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cdrage
Copy link
Member Author

cdrage commented Aug 22, 2017

@kadel I used the links directly from bintray but they were wrong.. thanks for the review! Updated the PR.

README.md Outdated

```sh
# Linux
curl -L https://dl.bintray.com/kedgeproject/kedge/latest/kompose-linux-amd64 -o kompose
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

link is not working :(

https://dl.bintray.com/kedgeproject/kedge/latest/kompose-linux-amd64 looks weird

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, my bad :-D

kedgeproject/kedge part is obviously wrong (my copy/paste error) :-(

kompose/kompose is supposed be there.

correct link is: https://dl.bintray.com/kompose/kompose/latest/kompose-linux-amd64

README.md Outdated
curl -L https://dl.bintray.com/kedgeproject/kedge/latest/kompose-linux-amd64 -o kompose

# macOS
curl -L https://dl.bintray.com/kedgeproject/kedge/latest/kompose-darwin-amd64 -o kompose
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

README.md Outdated

__Windows:__

Download from [Bintray](https://dl.bintray.com/kedgeproject/kedge/latest/kompose-windows-amd64.exe) and add the binary to your PATH.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

error 404 for this link


```sh
# Linux
curl -L https://dl.bintray.com/kedgeproject/kedge/latest/kompose-linux-amd64 -o kompose
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

curl -L https://dl.bintray.com/kedgeproject/kedge/latest/kompose-linux-amd64 -o kompose

# macOS
curl -L https://dl.bintray.com/kedgeproject/kedge/latest/kompose-darwin-amd64 -o kompose
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above


__Windows:__

Download from [Bintray](https://dl.bintray.com/kedgeproject/kedge/latest/kompose-windows-amd64.exe) and add the binary to your PATH.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above

@surajnarwade
Copy link
Contributor

If I goto this link https://dl.bintray.com/kedgeproject/kedge/latest/,
I can see,

  • kedge-darwin-amd64
  • kedge-linux-amd64
  • kedge-linux-arm
  • kedge-windows-amd64.exe

kompose is not there

@kadel
Copy link
Member

kadel commented Aug 24, 2017

you can find all the correct links here: https://dl.bintray.com/kompose/kompose/latest/

Sorry about confusion with Kedge :-(

Adds information on nightly builds to the README and installation
document.
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 25, 2017
@cdrage
Copy link
Member Author

cdrage commented Aug 25, 2017

I think this it the longest review for a doc every from mistypes, haha. Both @kadel and I had brainfarts.

Updated (again!).

@surajnarwade

@cdrage cdrage merged commit 8e6a148 into kubernetes:master Aug 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants