Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused parameter from ValidateComposeFile() #702

Merged
merged 1 commit into from
Jul 12, 2017

Conversation

concaf
Copy link
Contributor

@concaf concaf commented Jul 12, 2017

In pkg/app/app.go, the function ValidateComposeFile() has an
unused parameter "cmd *cobra.Command".

This commit removes that parameter from the function and the
callers of the function.

In pkg/app/app.go, the function ValidateComposeFile() has an
unused parameter "cmd *cobra.Command".

This commit removes that parameter from the function and the
callers of the function.
@kompose-bot
Copy link
Collaborator

@containscafeine, thank you for the pull request! We'll ping some people to review your PR. @procrypt, @cdrage and @surajssd, please review this.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 12, 2017
@procrypt
Copy link
Contributor

LGTM

@cdrage
Copy link
Member

cdrage commented Jul 12, 2017

LGTM

@cdrage cdrage merged commit 0143dee into kubernetes:master Jul 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants