Add support for stop_grace_period #608
Conversation
| in string | ||
| out *int64 | ||
| }{ | ||
| "5s": {in: "5s", out: &[]int64{5}[0]}, |
There was a problem hiding this comment.
can you add test case for only number like,
stop_grace_period: 2
There was a problem hiding this comment.
Sure. Stop_grace_period is stirng type so quotes are needed.
And fromSpecifying durations
stop_grace_period: '2'
should be invalid and has no effect.
|
@gitlawr , LGTM 👍 , let's wait for one more lgtm |
| } | ||
| duration, err := time.ParseDuration(s) | ||
| if err != nil { | ||
| log.Warningf("Failed to parse duration:%v", s) |
There was a problem hiding this comment.
nit: it would be great if this returns error, and at the place this function is called we emit log.Warningf since there we will also have info of which service has this problem.
The only problem with current approach is that we won't know which service is giving this particular warning!
|
@gitlawr thanks for this PR really appreciate it, apart from the above comment everything else LGTM! |
This commit Add support for stop_grace_period which maps to Pod.Spec.TerminationGracePeriodSeconds Updated conversion.md on support for the key
7ac20aa
to
c01f6f1
Compare
|
Updated and rebased. Thanks for the reviews! |
|
@gitlawr Thanks again for your contribution! We're inching closer and closer to full key coverage thanks to you! 👍 |
|
LGTM |
To solve #440
This commit Add support for stop_grace_period which maps to
Pod.Spec.TerminationGracePeriodSeconds
Updated conversion.md on support for the key