Adding tests for kompose-specific labels and buildconfig dockerfile construct #588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
59206ae
to
4917c27
Compare
|
Cc: @surajssd |
…onstruct * Two new scripts testing kompose-specific labels have been added: script/test_in_openshift/tests/routes-service-expose-hostname.sh script/test_in_openshift/tests/routes-service-expose-true.sh * Tests for buildconfig dockerfile construct has been added: script/test_in_openshift/tests/buildconfig_dockerfile.sh * Tests for restart option: script/test_in_openshift/tests/restart-options.sh * Ability to run individual scripts: Changes have been made to script/test_in_openshift/run.sh for running individual scripts: Eg. ./script/test_in_openshift/run.sh script/test_in_openshift/tests/routes-service-expose-true.sh
4917c27
to
43fa4a3
Compare
|
Two random files seem to have been added @ashetty1 ? Files |
be164d1
to
fb0966f
Compare
|
@cdrage deleted them. thanks. |
|
@cdrage @containscafeine @kadel @surajnarwade please to review :) |
|
Build worked for me, but test for |
|
I've tested this on the latest origin (master) as of today, and its using It got changed here: So I guess this is going to work for older |
kadel
approved these changes
Jun 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two new scripts testing kompose-specific labels have been added:
script/test_in_openshift/tests/routes-service-expose-hostname.sh
script/test_in_openshift/tests/routes-service-expose-true.sh
Ability to run individual scripts: Changes have been made to script/test_in_openshift/run.sh
for running individual scripts:
Eg. ./script/test_in_openshift/run.sh script/test_in_openshift/tests/routes-service-expose-true.sh