Update vendoring + fix issue with timestamps being added to log #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Closes #529 |
|
Thanks Charlie! This commit looks good to me in terms of /vendor/golang.org/x/sys update and should fix issue#532 |
|
@cdrage, do you have any comprehensive tests you can run? |
|
@dustymabe No comprehensive tests are being run right now, we're working on adding more integration tests. But unit tests + cmd tests are the only ones being ran at the moment. Yup. We can do another release on Monday! |
As per the vendoring here: kubernetes@e9544ca for some odd issue, text_formatter.go in the logrus package was updated to an older file. This commit updates the vendoring as well as specifies a specific version for logrus to be used. Closes + fixes kubernetes#532
|
sounds good. once you commit PR we can have @surajssd build an srpm from this commit (don't need a release yet) and I can run it through the fedora build system to verify everything works on ppc before you do a release. |
|
I've confirmed that this commit works and we've gotten a LGTM. Let's merge this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the vendoring here:
e9544ca
for some odd issue, text_formatter.go in the logrus package was updated
to an older file.
This commit updates the vendoring as well as specifies a specific
version for logrus to be used.