normalize docker-compose service that has name with underscore #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kadel
requested changes
Feb 14, 2017
pkg/loader/compose/compose_test.go
Outdated
| for _, testCase := range testCases { | ||
| returnValue := normalizeServiceNames(testCase.composeServiceName) | ||
| if returnValue != testCase.normalizedServiceName { | ||
| t.Log("Expected %q, got %q", testCase.normalizedServiceName, returnValue) |
kubernetes or openshift does not allow underscores in the object names, while docker-compose does, in this commit the code has been added to convert underscores to hypens.
28aa4b6
to
0bc24d5
Compare
cdrage
approved these changes
Feb 14, 2017
| {"foo_bar", "foo-bar"}, | ||
| {"foo", "foo"}, | ||
| {"foo.bar", "foo.bar"}, | ||
| //{"", ""}, |
|
|
||
| func normalizeServiceNames(svcName string) string { | ||
| return strings.Replace(svcName, "_", "-", -1) | ||
| } |
kadel
approved these changes
Feb 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kubernetes or openshift does not allow underscores in the object
names, while docker-compose does, in this commit the code has been
added to convert underscores to hypens.
Fixes #420