Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignores :z or :Z when passed in as a volume string #387

Merged
merged 1 commit into from
Jan 25, 2017
Merged

Ignores :z or :Z when passed in as a volume string #387

merged 1 commit into from
Jan 25, 2017

Conversation

cdrage
Copy link
Member

@cdrage cdrage commented Jan 20, 2017

We're going to ignore :z / :Z for labeling aka SELinux when being passed
in via Docker Compose.

Closes #176

@cdrage
Ignores :z or :Z when passed in as a volume string
b8006d0 
We're going to ignore :z / :Z for labeling aka SELinux when being passed
in via Docker Compose.

Closes kubernetes#176
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 20, 2017
@cdrage
Copy link
Member Author

cdrage commented Jan 20, 2017

Not too sure if this was the most-correct way of doing this @kadel but here's a try at it :)

rtnpro
rtnpro approved these changes Jan 24, 2017
View reviewed changes
Copy link
Contributor

@rtnpro rtnpro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

kadel
kadel approved these changes Jan 25, 2017
View reviewed changes
Copy link
Member

@kadel kadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kadel kadel merged commit 3f10691 into kubernetes:master Jan 25, 2017
@ankon
Copy link

ankon commented Feb 2, 2017

Note that the modes can be a comma-separated list: https://docs.docker.com/engine/reference/run/#/volume-shared-filesystems says

-v, --volume=[host-src:]container-dest[:<options>]: Bind mount a volume.
The comma-delimited `options` are [rw|ro], [z|Z],
[[r]shared|[r]slave|[r]private], and [nocopy].

@cdrage cdrage deleted the warn-if-passed-z-to-volume branch March 30, 2017 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kadel kadel kadel approved these changes

@rtnpro rtnpro rtnpro approved these changes

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@cdrage @ankon @kadel @rtnpro @k8s-ci-robot