Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated dev docs with latest instructions #341

Merged
merged 1 commit into from
Jan 4, 2017

Conversation

surajssd
Copy link
Member

cleaned up development docs to have latest changes

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 16, 2016
@coveralls
Copy link

Coverage Status

Coverage remained the same at 35.491% when pulling cc49305 on surajssd:build_instructions_update into 7bda857 on kubernetes-incubator:master.

cd $GOPATH/src/github.com/kubernetes-incubator
git clone https://github.com/$YOUR_GITHUB_USERNAME/kompose.git
cd kompose
git clone https://github.com/$YOUR_GITHUB_USERNAME/kompose.git $GOPATH/src/github.com/kubernetes-incubator/kompose
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will fail as there is no folder created. although kompose is no go getable, it may be good to simply put go get github.com/kubernetes-incubator/kompose here with the relevant docs.

Copy link
Member Author

@surajssd surajssd Jan 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will fail as there is no folder created.

directory will be created: man git clone gives following

git clone <repository> [<directory>]

<directory> = The name of a new directory to clone into. The "humanish" part of 
the source repository is used if no directory is explicitly given (repo for 
/path/to/repo.git and foo for host.xz:foo/.git). Cloning into an existing 
directory is only allowed if the directory is empty.

although kompose is no go getable, it may be good to simply put go get github.com/kubernetes-incubator/kompose here with the relevant docs.

kompose is go getable

```console
$ make binary
```
Read about building kompose [here](https://github.com/kubernetes-incubator/kompose#building).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

cleaned up development docs to have latest changes
@coveralls
Copy link

Coverage Status

Coverage remained the same at 46.617% when pulling 3decdd7 on surajssd:build_instructions_update into b059c44 on kubernetes-incubator:master.

@kadel kadel merged commit 6e260ba into kubernetes:master Jan 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants