Modify command in initializing unit tests #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kadel
reviewed
Oct 31, 2016
| for dir in $TEST_DIRS; do | ||
| go test "${TEST_FLAGS[@]}" "./${dir}" | ||
| done | ||
| go test -race -cover -v $( go list github.com/kubernetes-incubator/kompose/... | grep -v '/vendor/' ) |
There was a problem hiding this comment.
This looks much cleaner. To be honest I don't know why it was done using find. All other projects that I've looked at are also using find.
Lets try this and see what it will do ;-)
I would do just one change. To make sure same flags are used for tests and build. Can you add BUILD_FLAGS from .build?
f29709f
to
8787006
Compare
|
@kadel updated! |
This cleans up the current script we have to a simple one-liner to test unit tests.
kadel
approved these changes
Nov 1, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up the current script we have to a simple one-liner to test
unit tests.