Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update CHANGELOG #260

Merged
merged 2 commits into from
Nov 29, 2016
Merged

update CHANGELOG #260

merged 2 commits into from
Nov 29, 2016

Conversation

ngtuna
Copy link
Contributor

@ngtuna ngtuna commented Oct 31, 2016

No description provided.

## [v0.1.1](https://github.com/skippbox/kompose/tree/v0.1.1) (2016-10-06)
[Full Changelog](https://github.com/skippbox/kompose/compare/v0.1.0...v0.1.1)
## [v0.1.2](https://github.com/kubernetes-incubator/kompose/tree/v0.1.2) (2016-10-31)
[Full Changelog](https://github.com/kubernetes-incubator/kompose/compare/v0.1.1...v0.1.2)

**Implemented enhancements:**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering, what is difference between "Implemented enhancements" and "Closed issues"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I generated CHANGELOG using this tool. Issues marked with enhancement label will be sorted into implemented enhancements, bug label will be fixed bugs, otherwise are closed issues 😃

Copy link
Member

@kadel kadel Nov 6, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, ok :-) We have to start labeling all issues properly then.
It is little bin confusing as a lot of "enhancements" are just in Closed issues section.

can we maybe move those 3 issues to "closed issues" section?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, ok :-) We have to start labeling all issues properly then.

Yes that's good.

can we maybe move those 3 issues to "closed issues" section?

Yes that's pretty easy but I think we should keep the idea of classifying issues by label like this. That makes the CHANGLOG more specific. I will double-check the closed issues to see if any "enhancements" is missing. Will update shortly and let you know.

@sebgoa
Copy link
Contributor

sebgoa commented Nov 21, 2016

@ngtuna can you rebase...

@ngtuna
Copy link
Contributor Author

ngtuna commented Nov 24, 2016

@sebgoa Rebased.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 24, 2016
@sebgoa sebgoa merged commit 8036f07 into kubernetes:master Nov 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants