Create PVC object for docker-compose volumes #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7962fdb
to
1b43213
Compare
|
it would be great to test this on minikube, to make sure we know that this is now supported. |
|
thanks for including tests and fixtures. LGTM |
|
@sebgoa The fixture I have added can be directly fed to a running k8s cluster or OpenShift cluster provided you have PV already available. I tried it on minikube and a single node OpenShift cluster, and the mounts work. |
|
I created PV in minikube VM, using following artifact apiVersion: v1
kind: PersistentVolume
metadata:
name: vol1
labels:
type: local
spec:
capacity:
storage: 5Gi
accessModes:
- ReadWriteOnce
persistentVolumeReclaimPolicy: Retain
hostPath:
path: "/home/docker/data"Need to try the dynamic provisioning though! |
Instead of creating emptydir, create PersistentVolumeClaim for docker-compose volumes by default Fixes kubernetes#150
|
LGTM and tests are visible so this should be in 0.1.1 as well. Merging. |
|
@surajssd there was a test run failed on this PR. I'm looking on it |
|
Got it. kompose -f /home/travis/gopath/src/github.com/skippbox/kompose/script/test/fixtures/volume-mounts/simple-vol-mounts/docker-compose.yml convert --stdout --dcThat should include the new born |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of creating emptydir, create PersistentVolumeClaim for docker-compose volumes by default
Fixes #150