Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README + Docker Compose Bundle references #183

Merged
merged 1 commit into from
Oct 5, 2016

Conversation

cdrage
Copy link
Member

@cdrage cdrage commented Oct 3, 2016

This commit updates a few sentences in the README that I thought would
need improving.

Bundles now end with the .dab extension and are named "Distributed
Application Bundles" now. I've updated the README as well as the example
accordingly.

@surajssd
Copy link
Member

surajssd commented Oct 4, 2016

That is awesome clean up @cdrage Thanks for it 👍

@kadel
Copy link
Member

kadel commented Oct 4, 2016

LGTM 👍 . But I definitely shouldn't be the one reviewing anything written English 😃

@ngtuna
Copy link
Contributor

ngtuna commented Oct 5, 2016

That's also lgtm. You might want to take a look @sebgoa

file "web-deployment.json" created
file "redis-deployment.json" created

$ kompose docker-compose-bundle.yml convert
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is that a typo ? shouldn't it be docker-compose.yml ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah poop it is


`kompose` is a convenience tool to go from local Docker development to managing your application with Kubernetes. We don't assume that the transformation from docker compose format to Kubernetes API objects will be perfect, but it helps tremendously to start _Kubernetizing_ your application.
`kompose` is a convenience tool to go from local Docker development to managing your application with Kubernetes. Transformation of the Docker Compose format to Kubernetes API objects may not be 100% perfect, but it helps tremendously when first deploying to Kubernetes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there such a thing as 90% perfect ? how about "Transformation of the Docker Compose format to Kubernetes resources manifest may not be exact, but it helps tremendously when first deploying application on Kubernetes."

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, that's good! i'll update it to that

Copy link
Contributor

@sebgoa sebgoa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple comments


[![Build Status](https://travis-ci.org/skippbox/kompose.svg?branch=master)](https://travis-ci.org/skippbox/kompose) [![Join us on Slack](https://s3.eu-central-1.amazonaws.com/ngtuna/join-us-on-slack.png)](https://skippbox.herokuapp.com)

`kompose` is a tool to help users familiar with `docker-compose` move to [Kubernetes](https://kubernetes.io). It takes a Docker Compose file and translates it into Kubernetes resources.
`kompose` is a tool to help users whom are familiar with `docker-compose` move to [Kubernetes](https://kubernetes.io). `kompose` takes a Docker Compose file and translates it into Kubernetes resources.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will assume you are a native english speaker, and that the use of whom here is correct.

Copy link
Member Author

@cdrage cdrage Oct 5, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup nope, i'll fix it

@cdrage
Copy link
Member Author

cdrage commented Oct 5, 2016

@sebgoa updated it with your changes!

This commit updates a few sentences in the README that I thought would
need improving.

Bundles now end with the .dab extension and are named "Distributed
Application Bundles" now. I've updated the README as well as the example
accordingly.
@sebgoa sebgoa merged commit 676fead into kubernetes:master Oct 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants