Create service function in kubernetes utils #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surajssd
force-pushed
the
create-service
branch
from
5fb426e
to
052a1ba
Compare
|
This needs rebase on #106; please rename sc to svc (official short name for service) |
surajssd
force-pushed
the
create-service
branch
2 times, most recently
from
33d75f1
to
5dbd7ac
Compare
|
Rebased on #106 |
This function can be used in both openshift and kubernetes and all the logic of creating service can be kept in this function.
surajssd
force-pushed
the
create-service
branch
from
5dbd7ac
to
163a06d
Compare
|
ping @ngtuna |
|
Yeah LGTM. I thought @janetkuo did add |
ngtuna
added
the
lgtm
|
@ngtuna np, Thanks for reviewing 👍 Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function can be used in both openshift and kubernetes and all the logic of creating service can be kept in this function.