Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit test for komposeConvert #104

Merged
merged 1 commit into from
Aug 15, 2016
Merged

Add unit test for komposeConvert #104

merged 1 commit into from
Aug 15, 2016

Conversation

janetkuo
Copy link
Member

Ref #34

@janetkuo janetkuo mentioned this pull request Aug 12, 2016
Closed
@janetkuo janetkuo force-pushed the convert-unit-test branch 3 times, most recently from c3dd061 to 1fb77ab Compare August 13, 2016 00:31
@janetkuo janetkuo changed the title [WIP] Add unit test for komposeConvert Add unit test for komposeConvert Aug 13, 2016
@janetkuo
Copy link
Member Author

This PR is getting bigger than I thought. PTAL and I'll add more tests in follow-up PRs.

ngtuna
ngtuna reviewed Aug 15, 2016
View reviewed changes
pkg/kobject/kobject.go
@@ -162,19 +163,9 @@ type EnvVar struct {
type Ports struct {
HostPort int32
ContainerPort int32
Protocol Protocol
Protocol api.Protocol
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ngtuna
Copy link
Contributor

ngtuna commented Aug 15, 2016

Checked. That looks great 👍 @janetkuo

@ngtuna ngtuna added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 15, 2016
@janetkuo janetkuo merged commit 2fd923c into kubernetes:master Aug 15, 2016
@janetkuo janetkuo mentioned this pull request Aug 15, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. review needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janetkuo @ngtuna