By default, remove protocol: TCP in conversion to artifacts #392
Comments
cdrage
added a commit
to cdrage/kompose
that referenced
this issue
Jan 26, 2017
If TCP is passed in as the protocol, by default, we add TCP as the protocol within the Kubernetes or OpenShift artifacts. By default, TCP is already selected within Kubernetes and thus having the TCP output is redundant. This commit checks to see if TCP has already been selected, and if it has, ignores adding it to the list of ports. Closes kubernetes#392
cdrage
added a commit
to cdrage/kompose
that referenced
this issue
Jan 30, 2017
If TCP is passed in as the protocol, by default, we add TCP as the protocol within the Kubernetes or OpenShift artifacts. By default, TCP is already selected within Kubernetes and thus having the TCP output is redundant. This commit checks to see if TCP has already been selected, and if it has, ignores adding it to the list of ports. Closes kubernetes#392
cdrage
added a commit
to cdrage/kompose
that referenced
this issue
Jan 31, 2017
If TCP is passed in as the protocol, by default, we add TCP as the protocol within the Kubernetes or OpenShift artifacts. By default, TCP is already selected within Kubernetes and thus having the TCP output is redundant. This commit checks to see if TCP has already been selected, and if it has, ignores adding it to the list of ports. Closes kubernetes#392
cdrage
added a commit
to cdrage/kompose
that referenced
this issue
Jan 31, 2017
If TCP is passed in as the protocol, by default, we add TCP as the protocol within the Kubernetes or OpenShift artifacts. By default, TCP is already selected within Kubernetes and thus having the TCP output is redundant. This commit checks to see if TCP has already been selected, and if it has, ignores adding it to the list of ports. Closes kubernetes#392
cdrage
added a commit
to cdrage/kompose
that referenced
this issue
Jan 31, 2017
If TCP is passed in as the protocol, by default, we add TCP as the protocol within the Kubernetes or OpenShift artifacts. By default, TCP is already selected within Kubernetes and thus having the TCP output is redundant. This commit checks to see if TCP has already been selected, and if it has, ignores adding it to the list of ports. Closes kubernetes#392
cdrage
added a commit
to cdrage/kompose
that referenced
this issue
Feb 1, 2017
If TCP is passed in as the protocol, by default, we add TCP as the protocol within the Kubernetes or OpenShift artifacts. By default, TCP is already selected within Kubernetes and thus having the TCP output is redundant. This commit checks to see if TCP has already been selected, and if it has, ignores adding it to the list of ports. Closes kubernetes#392
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
By default, TCP is selected.
https://kubernetes.io/docs/api-reference/v1/definitions/#_v1_serviceport
We should not include
protocol: tcpin the resulting yaml / json conversion since it's already set by default.The text was updated successfully, but these errors were encountered: