Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--build should not automatically push #1363

Closed
mrvisser opened this issue Jan 30, 2021 · 5 comments · Fixed by #1405
Closed

--build should not automatically push #1363

mrvisser opened this issue Jan 30, 2021 · 5 comments · Fixed by #1405
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@mrvisser
Copy link

I'm concerned that the default configuration for kompose if you want kompose to build your images for you is to attempt to push company intellectual property to a public server.

Is it worth having a breaking change that defaults to not push?

Folks may be well-versed in contributing open source containers and have the configuration to deploy to dockerhub. Then they want to learn kubernetes and transfer their knowledge. They come across https://kubernetes.io/docs/tasks/configure-pod-container/translate-compose-kubernetes/ and see they can get their company's private docker repos running locally on kubernetes pretty easily. They follow the instructions and run kompose convert --build local just like in the docs to build locally and their intellectual property goes to a public server.

The kompose documentation says you can use --build to build and push your containers. But despite that I don't think anyone expects the default functionality of a "build" step is to push it to a public server.

Thankfully I don't have credentials to push to docker.io :)

@joebowbeer
Copy link

There is a --push-image boolean option, but it is true by default.

I would also like the default to be false.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 30, 2021
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 29, 2021
@k8s-triage-robot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

@k8s-ci-robot
Copy link
Contributor

@k8s-triage-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants