Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panic when converting Docker compose service with 'start_first' to kubernetes #1359

Closed
Johan-Lindvall-Stratsys opened this issue Nov 30, 2020 · 4 comments
Assignees
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@Johan-Lindvall-Stratsys

Given the following service definition

version: '3.5'

services:
  foo:
    image: image
    deploy:
      update_config:
        order: start-first

Kompose (version 1.22, locally built), crashes:

kompose.exe convert -f=crash.yml
panic: runtime error: invalid memory address or nil pointer dereference
[signal 0xc0000005 code=0x0 addr=0x0 pc=0x424d09]

goroutine 1 [running]:
k8s.io/apimachinery/pkg/util/intstr.(*IntOrString).String(0x0, 0xc0001e0250, 0xf39080)
        C:/Users/johan.lindvall/go/pkg/mod/k8s.io/[email protected]/pkg/util/intstr/intstr.go:93 +0x29
github.com/kubernetes/kompose/pkg/transformer/kubernetes.(*Kubernetes).InitD(0xc000178000, 0xc00008ec38, 0x3, 0x0, 0x0, 0xc0003c5510, 0x5, 0x0, 0x0, 0x0, ...)
        C:/source/kompose/pkg/transformer/kubernetes/kubernetes.go:382 +0x3fd
github.com/kubernetes/kompose/pkg/transformer/kubernetes.(*Kubernetes).CreateKubernetesObjects(0xc000178000, 0xc00008ec38, 0x3, 0x0, 0x0, 0xc0003c5510, 0x5, 0x0, 0x0, 0x0, ...)
        C:/source/kompose/pkg/transformer/kubernetes/kubernetes.go:1020 +0x1c8
github.com/kubernetes/kompose/pkg/transformer/kubernetes.(*Kubernetes).Transform(0xc000178000, 0xc0002b9500, 0xf2d354, 0x7, 0xc0002b91d0, 0x100000100, 0x0, 0x0, 0x0, 0x0, ...)
        C:/source/kompose/pkg/transformer/kubernetes/kubernetes.go:1165 +0x11a5
github.com/kubernetes/kompose/pkg/app.Convert(0x100000100, 0x0, 0x0, 0x0, 0x0, 0xf2b6e3, 0x4, 0x1, 0xf3cec4, 0x15, ...)
        C:/source/kompose/pkg/app/app.go:233 +0x282
github.com/kubernetes/kompose/cmd.glob..func3(0x1747be0, 0xc0003eec60, 0x0, 0x1)
        C:/source/kompose/cmd/convert.go:106 +0x58
github.com/spf13/cobra.(*Command).execute(0x1747be0, 0xc0003eec50, 0x1, 0x1, 0x1747be0, 0xc0003eec50)
        C:/Users/johan.lindvall/go/pkg/mod/github.com/spf13/[email protected]/command.go:846 +0x2c2
github.com/spf13/cobra.(*Command).ExecuteC(0x1747e80, 0x178558, 0x16fb400, 0xc000063f78)
        C:/Users/johan.lindvall/go/pkg/mod/github.com/spf13/[email protected]/command.go:950 +0x375
github.com/spf13/cobra.(*Command).Execute(...)
        C:/Users/johan.lindvall/go/pkg/mod/github.com/spf13/[email protected]/command.go:887
github.com/kubernetes/kompose/cmd.Execute()
        C:/source/kompose/cmd/root.go:92 +0x38
main.main()
        C:/source/kompose/main.go:22 +0x27
@hangyan hangyan self-assigned this Nov 30, 2020
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 28, 2021
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 30, 2021
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-contributor-experience at kubernetes/community.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hangyan hangyan reopened this Apr 30, 2021
This was referenced Apr 30, 2021
@hangyan hangyan closed this as completed May 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants