Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LocalStorageCapacityIsolationFSQuotaMonitoring revert to alpha for regression #3485

Merged
merged 1 commit into from
Sep 20, 2022

Conversation

pacoxu
Copy link
Member

@pacoxu pacoxu commented Aug 30, 2022

  • Other comments: only v1.25.0 is beta

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 30, 2022
@k8s-ci-robot k8s-ci-robot added the kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory label Aug 30, 2022
@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Aug 30, 2022
@pacoxu
Copy link
Member Author

pacoxu commented Aug 30, 2022

/cc @kikisdeliveryservice

@kikisdeliveryservice
Copy link
Member

Thanks @pacoxu ! I think the kep.yaml also needs the beta: 1.25 line updated: https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/1029-ephemeral-storage-quotas/kep.yaml

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 31, 2022
@pacoxu
Copy link
Member Author

pacoxu commented Aug 31, 2022

Thanks @pacoxu ! I think the kep.yaml also needs the beta: 1.25 line updated: https://github.com/kubernetes/enhancements/blob/master/keps/sig-node/1029-ephemeral-storage-quotas/kep.yaml

Updated. Missing the yaml.

@pacoxu pacoxu added this to Needs Reviewer in SIG Node PR Triage Aug 31, 2022
@kikisdeliveryservice
Copy link
Member

website update and changelog PR have both merged.

We just need to get this approved to have the enhancement reflect the correct state.

/lgtm
/assign @dchen1107 @derekwaynecarr

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 7, 2022
@pacoxu pacoxu moved this from Needs Reviewer to Needs Approver in SIG Node PR Triage Sep 9, 2022
@dchen1107
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dchen1107, pacoxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 20, 2022
@k8s-ci-robot k8s-ci-robot merged commit 111cfd7 into kubernetes:master Sep 20, 2022
SIG Node PR Triage automation moved this from Needs Approver to Done Sep 20, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.26 milestone Sep 20, 2022
@pacoxu pacoxu mentioned this pull request Aug 31, 2023
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep Categorizes KEP tracking issues and PRs modifying the KEP directory lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

5 participants