Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ConfigMap support for seccomp custom profiles #1269

Closed
wants to merge 12 commits into from
Closed

Add ConfigMap support for seccomp custom profiles #1269

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
da31c93
Initial draft
pjbgf Oct 2, 2019
ce0d940
Add Version Skew Strategy
pjbgf Oct 2, 2019
0483cd4
Add reviewers
pjbgf Oct 2, 2019
425bcc9
Fix mispelling.
pjbgf Oct 2, 2019
5cb0696
Add new seccomp profile type.
pjbgf Oct 2, 2019
3a28d21
Minor changes
pjbgf Oct 15, 2019
7bd2056
Add alternative of using CRDs instead
pjbgf Oct 17, 2019
097e699
Improvements based on feedback
pjbgf Oct 27, 2019
95c053a
Improve alternatives & add multiple files support
pjbgf Oct 29, 2019
19e9331
Add explict reference to namespace
pjbgf Oct 29, 2019
d9b66d7
Update keps/sig-node/20191002-seccomp-custom-profiles.md
pjbgf Apr 24, 2020
a94d0b8
Fix grammar mistakes
pjbgf Apr 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add alternative of using CRDs instead
  • Loading branch information
@pjbgf
pjbgf committed Oct 17, 2019
commit 7bd205698f4eb7cadae200efd6bb7e2d065d6a01
9 changes: 9 additions & 0 deletions keps/sig-node/20191002-seccomp-custom-profiles.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,10 +231,19 @@ The new configmap based profiles will only be supported from this version on. Us
## Implementation History
- 2019-10-02: Initial KEP
- 2019-10-15: Minor changes
- 2019-10-17: Add alternative to use CRD instead of ConfigMap


## Alternatives

**Use CRD instead of ConfigMap.** The decision to use `ConfigMap` was to avoid unnecessary complexity. Below are some key points from the [official guidance](https://kubernetes.io/docs/concepts/extend-kubernetes/api-extension/custom-resources/#should-i-use-a-configmap-or-a-custom-resource) which clarifies the reasoning:

- There is an existing, well-documented config file format.
- The entire config file will be stored into one key of a configMap.
- The main use of the config file is for the cluster to consume the file to pass it on to CRIs.
- Users could potentially perform rolling updates via Deployment, when the file is updated.
pjbgf marked this conversation as resolved.
Show resolved Hide resolved

pjbgf marked this conversation as resolved.
Show resolved Hide resolved

**Start deprecation process for `localhost/<path>`.** The new `ConfigMapSeccompProfile` will better support custom profiles. Starting the deprecation process would signal users what the end goal is. However, this can be started once the new approach GA's.


Expand Down