Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update cluster-autoscaler chart to 1.21.0 #4175

Merged
merged 1 commit into from
Jul 5, 2021

Conversation

mweibel
Copy link
Contributor

@mweibel mweibel commented Jul 1, 2021

No description provided.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 1, 2021
@mweibel mweibel changed the title update cluster-autoscaler chart to 1.12.0 update cluster-autoscaler chart to 1.21.0 Jul 1, 2021
@mweibel mweibel force-pushed the patch-1 branch 2 times, most recently from f93166e to b1b9651 Compare July 1, 2021 06:40
@mweibel
Copy link
Contributor Author

mweibel commented Jul 1, 2021

/assign @gjtempleton

@gjtempleton
Copy link
Member

Hey, thanks for the PR!

Can you please make the chart version bump a minor version bump rather than a patch version bump? It matches what we've done with past PRs to bump the default image and flags it as a larger change to users who are potentially using the default image tag.

@mweibel
Copy link
Contributor Author

mweibel commented Jul 5, 2021

sure, done :)

@gjtempleton
Copy link
Member

Brilliant, thanks again!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 5, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gjtempleton, mweibel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 5, 2021
@k8s-ci-robot k8s-ci-robot merged commit 7858da6 into kubernetes:master Jul 5, 2021
@mweibel mweibel deleted the patch-1 branch July 5, 2021 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants