Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CA-Chart Readme Updates & Fix Chart Lint and Test Actions #3932

Merged
merged 1 commit into from
Mar 9, 2021

Conversation

gjtempleton
Copy link
Member

  • Fixes What is the correct chart version ? #3899 by clarifying Helm chart versioning confusion, hides details under an expandable section and makes strong recommendation to use supported version
  • Updates the image for the repo to point at the raw kubernetes logo, for Artifact hub purposes, the current URL 404s
  • Updates the default Cluster-autoscaler image repository to the full vanity URL rather than the US endpoint, this should provide some speed benefits for non US based users
  • Fixes the helm testing and linting actions run on PRs, as per discussion on a previous PR this should have been caught by the action but due to the major version bump in the GH actions not also changing the invoking of the actions as per the Action's docs, they hadn't been successfully running, instead failing silently upon installing the actions. Tested as failing PRs which do not bump the chart version on my fork.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 8, 2021
CA-Chart - Update Readmes and Image location
Copy link
Contributor

@mwielgus mwielgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 9, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gjtempleton, mwielgus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 9, 2021
@k8s-ci-robot k8s-ci-robot merged commit ac1369f into kubernetes:master Mar 9, 2021
@gjtempleton gjtempleton deleted the CA-Chart-Updates branch March 15, 2021 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

What is the correct chart version ?
3 participants