Skip to content

Commit

Permalink
api: drop Resources.Claims from PVC and PVC template
Browse files Browse the repository at this point in the history
PVC and containers share the same ResourceRequirements struct. The Claims field
in it only makes sense when used in containers. When used in a PVC, the field
should have been rejected by validation. This was overlooked when introducing
it, so now persisted objects might have it set and/or people may have started
to rely on it being accepted even when it has no effect.

Therefore we cannot reject it in validation anymore, but we can still strip
it out on create or update.

Kubernetes-commit: bb8e051b4b95e1eb0e2dc4e3e25b4373a8a6307d
  • Loading branch information
pohly authored and k8s-publishing-bot committed Feb 21, 2023
1 parent 5fd8a44 commit 16f23da
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion core/v1/types.go
Original file line number Diff line number Diff line change
Expand Up @@ -2320,7 +2320,7 @@ type ResourceRequirements struct {
// This is an alpha field and requires enabling the
// DynamicResourceAllocation feature gate.
//
// This field is immutable.
// This field is immutable. It can only be set for containers.
//
// +listType=map
// +listMapKey=name
Expand Down

0 comments on commit 16f23da

Please sign in to comment.