Update comments on credential.domainJoinConfig

kubernetes-sigs · Sep 29, 2023 · c99bc40 · c99bc40
1 parent 3bc3f88
commit c99bc40
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 17 deletions.
diff --git a/charts/gmsa/templates/credentialspec.yaml b/charts/gmsa/templates/credentialspec.yaml
@@ -7,18 +7,18 @@ metadata:
 credspec:
  ActiveDirectoryConfig:
  GroupManagedServiceAccounts:
- - Name: {{ .Values.credential.domainJoinConfig.machineAccountName }}  #Username of the GMSA account
- Scope: {{ .Values.credential.domainJoinConfig.netBiosName }}  #NETBIOS Domain Name
- - Name: {{ .Values.credential.domainJoinConfig.machineAccountName }}  #Username of the GMSA account
- Scope: {{ .Values.credential.domainJoinConfig.dnsName }} #DNS Domain Name
+ - Name: {{ .Values.credential.domainJoinConfig.machineAccountName }} # Username of the GMSA account
+ Scope: {{ .Values.credential.domainJoinConfig.netBiosName }} # NETBIOS Domain Name
+ - Name: {{ .Values.credential.domainJoinConfig.machineAccountName }} # Username of the GMSA account
+ Scope: {{ .Values.credential.domainJoinConfig.dnsName }} # DNS Domain Name
  CmsPlugins:
  - ActiveDirectory
  DomainJoinConfig:
- DnsName: {{ .Values.credential.domainJoinConfig.dnsName }} #DNS Domain Name
- DnsTreeName: {{ .Values.credential.domainJoinConfig.dnsName }} #DNS Domain Name Root
- Guid: {{ .Values.credential.domainJoinConfig.guid }} #GUID
- MachineAccountName: {{ .Values.credential.domainJoinConfig.machineAccountName }} #Username of the GMSA account
- NetBiosName: {{ .Values.credential.domainJoinConfig.netBiosName }} #NETBIOS Domain Name
- Sid: {{ .Values.credential.domainJoinConfig.sid }} #SID of GMSA
+ DnsName: {{ .Values.credential.domainJoinConfig.dnsName }} # DNS Domain Name
+ DnsTreeName: {{ .Values.credential.domainJoinConfig.dnsName }} # DNS Domain Name Root
+ Guid: {{ .Values.credential.domainJoinConfig.guid }} # GUID of Domain
+ MachineAccountName: {{ .Values.credential.domainJoinConfig.machineAccountName }} # Username of the GMSA account
+ NetBiosName: {{ .Values.credential.domainJoinConfig.netBiosName }} # NETBIOS Domain Name
+ Sid: {{ .Values.credential.domainJoinConfig.sid }} # SID of Domain
 {{- end -}}
 
diff --git a/charts/gmsa/values.yaml b/charts/gmsa/values.yaml
@@ -11,12 +11,12 @@ certificates:
 credential:
  enabled: false
  domainJoinConfig:
- dnsName: ""  #DNS Domain Name
- dnsTreeName: "" #DNS Domain Name Root
- guid: ""  #GUID
- machineAccountName: "" #Username of the GMSA account
- netBiosName: ""  #NETBIOS Domain Name
- sid: "" #SID of GMSA
+ dnsName: "" # DNS Domain Name
+ dnsTreeName: "" # DNS Domain Name Root
+ guid: "" # GUID of Domain
+ machineAccountName: "" # Username of the GMSA account
+ netBiosName: "" # NETBIOS Domain Name
+ sid: "" # SID of Domain
 
 containerPort: "443"
 
@@ -25,7 +25,7 @@ image:
  tag: v0.7.0
  imagePullPolicy: IfNotPresent
 
-# if true, will add os fields to pod specs for K8s versions where feature is in beta (v1.24+)
+# If true, will add os fields to pod specs for K8s versions where feature is in beta (v1.24+)
 setPodOs: true
 
 global: