Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: disable testpackage linter #5448

Merged
merged 1 commit into from
Nov 15, 2023
Merged

chore: disable testpackage linter #5448

merged 1 commit into from
Nov 15, 2023

Conversation

stormqueen1990
Copy link
Member

Disable the testpackage linter as per #5430 (comment), for a few reasons:

  • It is currently only enforcing changes in new files, causing a drift between the pattern of existing test packages vs. the pattern of newly added test packages.
  • It's preferrable to have tests sit in the same package as the code the tests touch, since Kustomize does open-box testing for the time being.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 15, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 15, 2023
@stormqueen1990
Copy link
Member Author

/cc @natasha41575 @ncapps @charles-chenzz

@stormqueen1990 stormqueen1990 mentioned this pull request Nov 15, 2023
Merged
charles-chenzz
charles-chenzz reviewed Nov 15, 2023
View reviewed changes
Copy link
Member

@charles-chenzz charles-chenzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 15, 2023
ncapps
ncapps reviewed Nov 15, 2023
View reviewed changes
Copy link
Contributor

@ncapps ncapps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for tracking this one!
/lgtm

natasha41575
natasha41575 approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@natasha41575 natasha41575 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: natasha41575, stormqueen1990

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 15, 2023
@k8s-ci-robot k8s-ci-robot merged commit 8b52e04 into kubernetes-sigs:master Nov 15, 2023
9 checks passed
@stormqueen1990 stormqueen1990 mentioned this pull request Nov 18, 2023
Merged
@ncapps ncapps mentioned this pull request Dec 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ncapps ncapps ncapps left review comments

@charles-chenzz charles-chenzz charles-chenzz left review comments

@natasha41575 natasha41575 natasha41575 approved these changes

@annasong20 annasong20 Awaiting requested review from annasong20

@yuwenma yuwenma Awaiting requested review from yuwenma

Assignees

@ncapps ncapps

@natasha41575 natasha41575

@charles-chenzz charles-chenzz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Kustomize CI, release Improvements, telemetry, & refactors
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@stormqueen1990 @k8s-ci-robot @ncapps @natasha41575 @charles-chenzz