helm: remove HELM_CONFIG_HOME default tmp value #5434
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: MrFreezeex The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
c84a5f8
to
711dc05
Compare
`HELM_CONFIG_HOME` is supposed to contain two files `repositories.yaml` and `repositories.lock`. Kustomize sets by default `HELM_CONFIG_HOME` to an empty tmp dir not populated with any of the `repositories.*` files which prevent Helm from pulling private OCI repo for instance (even if this repo is not listed in `repositories.yaml`). This commits remove the default value to a tmpdir. Kustomize will thus not populate `HELM_CONFIG_HOME`, `HELM_CACHE_HOME` and `HELM_DATA_HOME` by default anymore. User can still override this directory with `helmGlobals`. Setting `configHome` in global to the normal helm config location (`/home/MY_USER_HERE/.config/helm`) could also be used as a workaround before this commit. Related to kubernetes-sigs#5407 Signed-off-by: Arthur Outhenin-Chalandre <[email protected]>
711dc05
to
9e94760
Compare
|
/triage under-consideration #5407 is still labeled as triage/under-consideration and needs further discussion to reach a final decision. If you are interested in the feature please feel free to leave a comment there describing your use case, that will help to stir up conversation. If the feature request becomes popular, the use cases are compelling enough to support the feature, and it fits into kustomize design principles, we can triage/accept the feature and prioritize it then. The main blocking point (as described on the issue) is:
If you would like to help move that forward, we would appreciate if you would consider doing that research and leaving your findings on the issue. |
|
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
|
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
|
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
|
@k8s-triage-robot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
HELM_CONFIG_HOMEis supposed to contain two filesrepositories.yamlandrepositories.lock. Kustomize sets by defaultHELM_CONFIG_HOMEto an empty tmp dir not populated with any of therepositories.*files which prevent Helm from pulling private OCI repo for instance (even if this repo is not listed inrepositories.yaml).This commits remove the default value to a tmpdir. Kustomize will thus not populate
HELM_CONFIG_HOME,HELM_CACHE_HOMEandHELM_DATA_HOMEby default anymore. User can still override this directory withhelmGlobals. SettingconfigHomein global to the normal helm config location (/home/MY_USER_HERE/.config/helm) could also be used as a workaround before this commit.Fixes #5407