fixes issue with windows release binary name #5410

[bb-Ricardo]

This should solve the issue with binary suffixes for windows releases #5410.

[linux-foundation-easycla]

• ❌ - login: @bb-Ricardo / name: Ricardo . The commit (be04e82) is not authorized under a signed CLA. Please click here to be authorized. For further assistance with EasyCLA, please submit a support request ticket.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bb-Ricardo
Once this PR has been reviewed and has the lgtm label, please assign natasha41575 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Welcome @bb-Ricardo!

It looks like this is your first PR to kubernetes-sigs/kustomize 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kustomize has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @bb-Ricardo. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[charles-chenzz]

can you sign the CLA so that we can process your PR?
#5415 (comment)

[bb-Ricardo]

can you sign the CLA so that we can process your PR? #5415 (comment)

Currently awaiting internal approval

[bb-Ricardo]

The approval has been given but not sure how to trigger the check again.

[natasha41575]

@bb-Ricardo The CLA check should automatically update. Can you make sure the commits on here are associated with the email address that you signed the CLA with? If they are, you might have to follow the links in #5415 (comment) for further troubleshooting.

[bb-Ricardo]

@bb-Ricardo The CLA check should automatically update. Can you make sure the commits on here are associated with the email address that you signed the CLA with? If they are, you might have to follow the links in #5415 (comment) for further troubleshooting.

I have followed the link as a corporate contributor, requested approval from our CLA Manager, filled in details and send the form. Then I asked our CLA Manager and he said he approved the request. If I follow the link again I can only restart the same process.

[natasha41575]

@bb-Ricardo I'm sorry, but there isn't really anything we can do to help if the CLA check isn't recognizing your username - this is a requirement from CNCF. Are you certain that the commits are associated with the email that has the CLA authorization? If so, then the only thing you can do from there is file a support ticket

[bb-Ricardo]

Hey,

I don't actually care who submits this PR. If you have someone, just grab the commit, close the PR and submit a new PR.

Really can't be bothered with all this fuss for these view lines of code.

Would this be possible?

[bb-Ricardo]

And yes, my account is associated with two email addresses. Which one would be the relevant one?

[charles-chenzz]

@bb-Ricardo hi, I would try to pick up the commit and co-author you and submit a new PR. but it might require you to track on that PR. would it make sense to you?

[bb-Ricardo]

Sure, no problem

[charles-chenzz]

see #5439 think it's safe to close this one
/close

[k8s-ci-robot]

@charles-chenzz: Closed this PR.

In response to this:

see #5439 think it's safe to close this one
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.