Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add namespace option to 'edit add configmap' command #5367

Merged
merged 4 commits into from
Oct 14, 2023
Merged

fix: add namespace option to 'edit add configmap' command #5367

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
11aa57e
fix: add --namespace flag to edit add configmap
stormqueen1990 Oct 9, 2023
6ef9773
docs: update comment to reflect usage of namespace
stormqueen1990 Oct 9, 2023
6cb85e8
fix: remove unnecessary empty space as per lint
stormqueen1990 Oct 9, 2023
7a08dde
fix: change spaces for tabs
stormqueen1990 Oct 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
docs: update comment to reflect usage of namespace 
Update the comment for the namespace option to reflect its real usage for both
secret and configmap.
  • Loading branch information
@stormqueen1990
stormqueen1990 committed Oct 9, 2023
commit 6ef9773c02d7e939e951ca20c4b51a3de4b7be5d
2 changes: 1 addition & 1 deletion api/types/generatorargs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ package types

// GeneratorArgs contains arguments common to ConfigMap and Secret generators.
type GeneratorArgs struct {
// Namespace for the configmap, optional
// Namespace for the resource, optional
Namespace string `json:"namespace,omitempty" yaml:"namespace,omitempty"`

// Name - actually the partial name - of the generated resource.
Expand Down
Loading