refactor: rename valtest_test and testutils_test imports

[stormqueen1990]

Rename the usages of the testutils and valtest utilities from testutils_test to testutils and valtest_test to valtest.

There are at least two other packages I found that are being used with a similar naming pattern: kusttest and resmaptest.

This is based on feedback given in #5315 (comment)

/hold for discussion and until #5315 is merged

[k8s-ci-robot]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: stormqueen1990
Once this PR has been reviewed and has the lgtm label, please assign natasha41575 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[natasha41575]

So if you go to the package where these test helpers are defined, the name of the package is actually valtest_test. I think this is pretty standard for test packages (so that it gets compiled separately from the main package).

I'm not really sure it matters whether we name the import valtest or valtest_test - kind of seems like we are trying to decide between using the package name or the directory name. To me using the actual package name valtest_test seems to make more sense.

I think what does matter is that we choose one pattern and stick to it, so I'd be inclined to leave it as valtest_test since that seems to have been the convention so far. Again I really don't think it matters too much so I could be convinced otherwise if someone feels there is a strong reason to change it.

[stormqueen1990]

This makes sense to me. I'll close this for the time being, as I mainly opened so we could discuss.

/close

[k8s-ci-robot]

@stormqueen1990: Closed this PR.

In response to this:

This makes sense to me. I'll close this for the time being, as I mainly opened so we could discuss.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.