-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updated script to install non module versions of kustomize #4131
updated script to install non module versions of kustomize #4131
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @nasir-rabbani! |
Hi @nasir-rabbani. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: nasir-rabbani The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
signed CLA |
/ok-to-test |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
@@ -25,11 +25,54 @@ unset CDPATH | |||
|
|||
where=$PWD | |||
|
|||
function getTagName () { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In trying to figure out how this works (I'm not great at bash!) I discovered it seems to be taken from StackOverflow. Since that uses a CC BY-SA 4.0 license, I don't think we can accept it--Kustomize uses Apache 2.0.
That said, we are dealing with a well-known set of tags here, and both they and our input are guaranteed (by the regex at L73) to have three digits, which makes the task much simpler than the general case. In fact, I'd suggest going with the most naive solution of literally checking the list of exceptions, e.g.:
function getTagName () {
local requested=$1
# The complete list of tags published before we started prefixing
local unprefixedTags=(v1.0.0 v1.0.1 v1.0.10 v1.0.11 v1.0.2 v1.0.3 v1.0.4 v1.0.5 v1.0.6 v1.0.7 v1.0.8 v1.0.9 v2.0.0 v2.0.1 v2.0.2 v2.0.3 v2.1.0 v3.0.0 v3.0.1 v3.0.2 v3.0.3 v3.1.0 v3.2.0 v3.3.0 v3.3.1)
for tag in ${unprefixedTags[@]}; do
if [[ $tag = "v$requested" ]]; then
echo "v$requested"
return 0
fi
done
echo "kustomize/v$requested"
return 0
}
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
@k8s-triage-robot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This PR aims to add support of installing the module as well as non module version of kustomize using the install_kustomize.sh script. Related issue : #4130