-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flag --enable-helm #3784
Merged
Merged
Add flag --enable-helm #3784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: monopole The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
labels
Apr 8, 2021
/test kustomize-presubmit-master |
monopole
force-pushed
the
flagEnableHelm
branch
3 times, most recently
from
April 8, 2021 19:59
2bb7584
to
cebda71
Compare
k8s-ci-robot
added
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
and removed
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
labels
Apr 8, 2021
k8s-ci-robot
added
the
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
label
Apr 9, 2021
monopole
force-pushed
the
flagEnableHelm
branch
13 times, most recently
from
April 11, 2021 00:53
c2f8b35
to
76faa15
Compare
monopole
force-pushed
the
flagEnableHelm
branch
from
April 12, 2021 02:29
21e0286
to
e286c84
Compare
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
Indicates that a PR should not merge because it is a work in progress.
label
Apr 12, 2021
/retest |
monopole
force-pushed
the
flagEnableHelm
branch
4 times, most recently
from
April 12, 2021 18:19
8feb8e8
to
f2d1679
Compare
plugin/builtin/helmchartinflationgenerator/HelmChartInflationGenerator.go
Outdated
Show resolved
Hide resolved
plugin/builtin/helmchartinflationgenerator/HelmChartInflationGenerator.go
Outdated
Show resolved
Hide resolved
monopole
force-pushed
the
flagEnableHelm
branch
2 times, most recently
from
April 12, 2021 20:39
828cd18
to
4add711
Compare
monopole
force-pushed
the
flagEnableHelm
branch
from
April 12, 2021 20:40
4add711
to
240cda0
Compare
/lgtm |
k8s-ci-robot
added
the
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
label
Apr 12, 2021
This was referenced Apr 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by an approver from all required OWNERS files.
cncf-cla: yes
Indicates the PR's author has signed the CNCF CLA.
lgtm
"Looks good to me", indicates that a PR is ready to be merged.
size/XXL
Denotes a PR that changes 1000+ lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two command line flags to
kustomize build
and changes behavior accordingly.
Please read
examples/chart.md
in this PR.That file has been activated as an end-to-end test.
The helm plugin tests have also been activated.
Flags
Kustomize won't spawn a helm subprocess unless
--enable-helm
isspecified.
The helm command defaults to simply
helm
, and it must be on theuser's
PATH
. To override this requires use of the--helm-command
flag.This is a command line parameter rather than a config parameter to
mitigate config download risks.
Fields
The existing kustomization field
HelmChartInflationGenerator
is stillmostly honored, but now deprecated.
It's replaced by two new fields, explained in detail in this PR's
helmchartargs.go
file.The fields have been split into two groups,
HelmCharts
andHelmGlobals
, with the former containing chart specific info, and thelatter containing general helm options.
The
HelmBin
,ExtraArgs
from theHelmChartInflationGenerator
fieldare ignored because they represent a security risk which bears further examination.
The purpose served by
HelmBin
is now served by the--helm-command
flag.Also, the
ReleaseNamespace
field is ignored, as it doesn't work inhelm's template mode, and kustomize has it's own way of specifying
namespace.
ALLOW_MODULE_SPAN