Name Prefix and Suffix Transformation for multi level level kustomize context #1378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @Liujingfang1 |
8b6fdf5
to
96c85cb
Compare
This was referenced Jul 22, 2019
|
It seems this PR fixes:
|
This was referenced Jul 22, 2019
bd2110d
to
fc7f6ae
Compare
|
@Liujingfang1 Gentle bump of the PR. Rebase was successful |
|
@jbrette Thank you. Will review it today. |
|
@Liujingfang1 This is done. I did the changes and repushed. Thanks for the review. Was able to simplify even further. Can you have a look at it again. |
- Update PrefixSuffixTransfomer to add empty prefix and suffix
pkg/resmap/resmap.go
Outdated
| // Need to match more accuratly both at the time of selection and transformation. | ||
| // OutmostPrefixSuffixEquals is not accurate enough since it is only using | ||
| // the outer most suffix and the last prefix. Use PrefixedSuffixesEquals instead. | ||
| if (!inputId.IsNamespaceableKind() && r.InSameKustomizeCtx(rctxm)) || |
There was a problem hiding this comment.
(!inputId.IsNamespaceableKind() || !r.OrgId().IsNamespaceableKind || r.CurId.IsNsEquals(input)) && r.InSameKustomizeCtx(rctxm)
There was a problem hiding this comment.
@Liujingfang1 Sorry. Should have seen that. This is done now. Ready for merge I hope.
- Leverage nameprefix and namesuffix contextual data
- Update unit and integration tests.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jbrette, Liujingfang1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on the "OuterMost" Prefix and Suffix usage for the name transformation.
Current code was unable to deal properly with a last level of kustomize that was combining two sub levels. In such as case the outermost prefix and suffix where often empty.
This PR is using the stack of prefixes and suffixes accumulated during the name prefix/suffix transformation to handle properly the namereference transformation.
The ResCtx (Resource Context) interface has been introduced. It is currently relying on name prefix and suffix but long term it should be possible to extend it to use a filename or a commit id equivalent to identify a kustomize content (a.k.a a folder with a kustomization.yaml).