Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add complex overlay composition test #1297

Merged
merged 1 commit into from
Jul 2, 2019
Merged

Add complex overlay composition test #1297

merged 1 commit into from
Jul 2, 2019

Conversation

ioandr
Copy link
Contributor

@ioandr ioandr commented Jul 2, 2019

This PR adds a test with a complex kustomization scenario that combines patches with custom resources and generators.

The provided test does not reach the assertion phase, since it causes kustomize to fail with:

recursed merging from path: ... may not add resource with an already registered id

Related with:

nit: Some fields of the expected output YAML strings in comments might need reordering.

Signed-off-by: Ioannis Androulidakis <[email protected]>
Signed-off-by: Alex Pyrgiotis <[email protected]>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 2, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ioandr
To complete the pull request process, please assign droot
You can assign the PR to them by writing /assign @droot in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 2, 2019
@monopole
Copy link
Contributor

monopole commented Jul 2, 2019

👍 👍

/lgtm

Great starting point.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 2, 2019
@monopole monopole merged commit 60a990d into kubernetes-sigs:master Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants