-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't patch Pod - no matches for Id Pod.v1.[noGrp]/airbyte-minio-create-bucket.airbyte #5687
Comments
@harshsingh32: The label In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Hello there, @AurimasNav! I took a look at this Helm chart by running # Source: airbyte/templates/minio.yaml
# This pod creates the state-storage bucket in the minio server,
# which the local cloud deployment requires to store its state.
apiVersion: v1
kind: Pod
metadata:
name: airbyte-minio-create-bucket
annotations:
"helm.sh/hook": post-install, post-upgrade
"helm.sh/hook-delete-policy": hook-succeeded, before-hook-creation
spec:
... I could also confirm this is the case here: https://github.com/airbytehq/airbyte-platform/blob/801feb0da0af30b86961c0e92b8e0ae72000016a/charts/airbyte/templates/minio.yaml#L110-L119 Therefore, for your patch to get correctly applied, it would have to be: apiVersion: v1
kind: Pod
metadata:
name: airbyte-minio-create-bucket
labels:
sidecar.istio.io/inject: "false" After updating the patch as specified above, I can correctly generate the manifests with apiVersion: v1
kind: Pod
metadata:
annotations:
helm.sh/hook: post-install, post-upgrade
helm.sh/hook-delete-policy: hook-succeeded, before-hook-creation
labels:
sidecar.istio.io/inject: "false"
name: airbyte-minio-create-bucket
namespace: airbyte
spec:
... Could you please confirm it works for you after the aforementioned change? /kind support |
/triage needs-information |
What happened?
I am unable to patch a pod from specific helm chart.
I was not able to replicate this with plain yaml files, only in with this helm chart.
What did you expect to happen?
one of the resources from this helm chart is a pod:
I expect it to patch with my label successfully, however it produces an error:
How can we reproduce it (as minimally and precisely as possible)?
kustomization.yaml
no-istio-sidecar.yaml
values.yaml
Expected output
Actual output
Error: no resource matches strategic merge patch "Pod.v1.[noGrp]/airbyte-minio-create-bucket.airbyte": no matches for Id Pod.v1.[noGrp]/airbyte-minio-create-bucket.airbyte; failed to find unique target for patch Pod.v1.[noGrp]/airbyte-minio-create-bucket.airbyte
Kustomize version
v5.4.1
Operating system
MacOS
The text was updated successfully, but these errors were encountered: