Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple protocols are clobbered when rendering ports #558

Closed
cmhillerman opened this issue Nov 19, 2018 · 5 comments
Closed

Multiple protocols are clobbered when rendering ports #558

cmhillerman opened this issue Nov 19, 2018 · 5 comments
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@cmhillerman
Copy link

cmhillerman commented Nov 19, 2018

In the ports section of a manifest, if you are trying to set UDP and TCP for a port, only one of the ports is rendered in kustomize. E.g. If you have:

        ports:
            - containerPort: 53
              hostPort: 53
              hostIP: 0.0.0.0
            - containerPort: 53
              hostPort: 53
              protocol: UDP
              hostIP: 0.0.0.0

And when you run kustomize build you get:

        ports:
        - containerPort: 53
          hostIP: 0.0.0.0
          hostPort: 53

This is because containerPort is used as the key to the hash. Maybe if we forced people to use name in all ports and used that as the key? Or using name as the key if the name exists?

I also could be confused and there's a workaround or something I'm missing?

@mengqiy
Copy link
Member

mengqiy commented Nov 27, 2018

@monopole @Liujingfang1 Please check kubernetes/kubernetes#39188 for the root cause.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 27, 2019
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 27, 2019
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

4 participants