Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kubectl kustomize version should report version info #2142

Closed
nicks opened this issue Jan 22, 2020 · 7 comments
Closed

kubectl kustomize version should report version info #2142

nicks opened this issue Jan 22, 2020 · 7 comments
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@nicks
Copy link

nicks commented Jan 22, 2020

Expected behavior:

kubectl kustomize version

should print information about the version of Kustomize templates that kubectl kustomize accepts, similar to the kustomize version command

Actual behavior

kubectl kustomize version

doesn't work.

The kubectl command only accepts kustomize version 2+, but the main kustomize repo is on version 3+. This has caused some confusion for our users, because they thought that they should be using the "new way" of preferring kubectl kustomize over kustomize

Obviously, we could work around this by keeping a map from kubectl versions to compatible kustomize versions, but it would be nice if we could get this info from kubectl kustomize

PS -- I also filed kubernetes/kubectl#797, but someone there commented that this belongs in the kustomize repo. I'm not totally clear on the relationship between kustomize team and the kubectl team, and why kustomize version is in one but not the other. Happy to redirect conversation to the appropriate place!

@nicks nicks changed the title kubectl kustomize versopm should report version info kubectl kustomize version should report version info Jan 22, 2020
@leoskyrocker
Copy link

as an aside - should you not prefer kubectl kustomize over kustomize?

@davidnqd
Copy link

davidnqd commented Feb 18, 2020

Should it be in --help or --version? (Just to avoid conflict with a possible ./version in the cwd)

@greenstatic
Copy link

Should it be in --help or --version? (Just to avoid conflict with a possible ./version in the cwd)

It should probably be simply kubectl kustomize version since the version subcommand is present in kustomize (kustomize version) and even kubectl (kubectl version). Having two sets of CLI syntaxes for the same program (kustomize) will probably be confusing,

Regarding the name clash with a file named version in the cwd, maybe it would be better not to link kubectl kustomize to kustomize build and to have the build argument in there?

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 5, 2020
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 4, 2020
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

6 participants