Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support kustomize edit add labels (and annotations) #13

Closed
monopole opened this issue May 18, 2018 · 7 comments
Closed

Support kustomize edit add labels (and annotations) #13

monopole opened this issue May 18, 2018 · 7 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.
Milestone

Comments

@monopole
Copy link
Contributor

No description provided.

@guineveresaenger
Copy link
Contributor

Will work on this

@monopole monopole added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label May 21, 2018
@guineveresaenger
Copy link
Contributor

@monopole @Liujingfang1 - this is asking for entries to be added to the commonAnnotations and commonLabels entries in kustomization.yaml, yes?

I'm assuming we would like the ability to add more than one label or annotation at the same time.

Let me know if there's more details to consider!

@guineveresaenger
Copy link
Contributor

Random question: is it possible to add labels that are specific to each resource referenced in kustomization.yaml (i.e. are not "common")? Or is that currently only possible by including labels in resource patches?

@Liujingfang1
Copy link
Contributor

this is asking for entries to be added to the commonAnnotations and commonLabels entries in kustomization.yaml, yes?

kustomize edit add labels is for adding entries to commonLabels
kustomize edit add annotations is for adding entries to commonAnnotations

is it possible to add labels that are specific to each resource referenced in kustomization.yaml (i.e. are not "common")? Or is that currently only possible by including labels in resource patches?

commonLabels are to be added to each resource in the kustomization. If you want to add specific labels to certain resource, you can add labels in that resource file.

@guineveresaenger
Copy link
Contributor

/assign

@k8s-ci-robot
Copy link
Contributor

@guineveresaenger: GitHub didn't allow me to assign the following users: guineveresaenger.

Note that only kubernetes-sigs members and repo collaborators can be assigned.

In response to this:

/assign

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Liujingfang1 Liujingfang1 added this to the 1.0.4 milestone Jul 11, 2018
@Liujingfang1 Liujingfang1 modified the milestones: 1.0.4, 1.0.6 Aug 2, 2018
@monopole
Copy link
Contributor Author

Fixed by #147

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.
Projects
None yet
Development

No branches or pull requests

4 participants