Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add markdown CI #5380

Merged
merged 1 commit into from
Dec 4, 2019
Merged

Conversation

Miouge1
Copy link
Contributor

@Miouge1 Miouge1 commented Nov 26, 2019

What type of PR is this?
/kind cleanup
/kind feature

What this PR does / why we need it:
Making the doc more readable and consistent.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 26, 2019
@Miouge1
Copy link
Contributor Author

Miouge1 commented Nov 26, 2019

@mattymo that comment #5267 (comment) got me thinking that we might want to introduce some automatic linting of Markdown files.

This PR enables it only on README.md and docs/*.md so that we can get things moving without to fix all of contrib/ :)

@Miouge1 Miouge1 mentioned this pull request Nov 26, 2019
@Miouge1 Miouge1 changed the title WIP: Add markdown CI Add markdown CI Dec 4, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 4, 2019
@mattymo
Copy link
Contributor

mattymo commented Dec 4, 2019

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 4, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattymo, Miouge1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit a9b67d5 into kubernetes-sigs:master Dec 4, 2019
erulabs added a commit to kubesail/kubespray that referenced this pull request Dec 5, 2019
* 'master' of https://github.com/kubernetes-sigs/kubespray:
  Add support to Ansible 2.9 (kubernetes-sigs#5361)
  Add toleration for calico-typha on master (kubernetes-sigs#5405)
  Add CI for Amazon Linux 2 (kubernetes-sigs#5410)
  Add support for Debian 10 (kubernetes-sigs#5408)
  Add OIDC to CI (kubernetes-sigs#5407)
  Fix Python code style for inventory_builder (kubernetes-sigs#5362)
  update oidc to contain quotes (kubernetes-sigs#5406)
  Add markdown CI (kubernetes-sigs#5380)
  Update to TF v0.12.12 (kubernetes-sigs#5267)
  Fix OpenSUSE support (kubernetes-sigs#5370)
  Allow customizing kubelet healthz port and bind addr (kubernetes-sigs#5403)
  force other resolvers to be secondary when using systemd-resolved (kubernetes-sigs#5391)
  Allow inventory_builder to add nodes with hostname (kubernetes-sigs#5398)
LuckySB pushed a commit to southbridgeio/kubespray that referenced this pull request Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants