-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix references to sample files in setup.cfg #4882
Conversation
Welcome @edwinpjacques! |
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/assign @Atoms |
ci check this |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Atoms, edwinpjacques The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind failing-test
What this PR does / why we need it:
Resolving issue #4881, which made it so that a wheel could not be built.
Which issue(s) this PR fixes:
Fixes #4881
Special notes for your reviewer:
To test before/after, simply checkout and run this command to try to build the wheel:
python3 setup.py sdist bdist_wheel
It used to fail and now it works. There is no change to actual Kubespray playbooks or dependencies, so this should be easy to accept, I hope.
Does this PR introduce a user-facing change?: