-
Notifications
You must be signed in to change notification settings - Fork 662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(podlifetime): fix failed unittest #1334
fix(podlifetime): fix failed unittest #1334
Conversation
1. correct desired pod creation time
Welcome @xujihui1985! |
Hi @xujihui1985. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
/retest |
@xujihui1985 nice catch!!! I wonder how "Two pods in the Also, |
I happened to run the test in my ci system, and can't pass this test, so I look into the test and find out the test condition might be wrong, but I haven't check why this test used to be success. |
Running the test from the current master:HEAD it passes. Though only because the computation overflows:
The code does not assume a pod gets created in the future :) Dropping uint the case fails. |
@xujihui1985 would you please also update the filter code as well? E.g.
@a7i we should probably ignore any pod created in the future :) |
sure, glad to do that |
when the pod createtimestamp is greater than the current time (which is not make sense in real life, but when doing test with such case, it is possible), it will convert to a large number if we convert it to uint, and though it can pass the test, but doesn't make sense.
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ingvagabund The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I see, covert to uint make the podAgeSeconds a large number because of the nagtive sign, I have update the MR according to your suggestion, but actually this future pod doesn't make sense in real life, so either we compare the creation seconds with convert it to int or if (podAgeSeconds < 0), we just return false |
/retest |
/lgtm |
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [descheduler](https://togithub.com/kubernetes-sigs/descheduler) | minor | `0.29.0` -> `0.30.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>kubernetes-sigs/descheduler (descheduler)</summary> ### [`v0.30.0`](https://togithub.com/kubernetes-sigs/descheduler/releases/tag/v0.30.0): Descheduler v0.30.0 [Compare Source](https://togithub.com/kubernetes-sigs/descheduler/compare/v0.29.0...v0.30.0) #### What's Changed - fix(podlifetime): fix failed unittest by [@​xujihui1985](https://togithub.com/xujihui1985) in [kubernetes-sigs/descheduler#1334 - `PodLifeTime`: update support pods with container status and pods reason by [@​dongjiang1989](https://togithub.com/dongjiang1989) in [kubernetes-sigs/descheduler#1330 - v1alpha1: log deprecation notice by [@​a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1337 - feat: Add support for topologySpreadConstraints by [@​UAntBou](https://togithub.com/UAntBou) in [kubernetes-sigs/descheduler#1289 - chore: update dependencies for security vulnerabilities (CVE-2023-48795) by [@​a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1343 - trim managedFields in shared informer factory by [@​a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1346 - fix: `RemovePodsHavingTooManyRestarts` to include `InitContainerStatuses` by [@​a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1348 - Improve PodEvictor observability through EvictOptions by [@​tioxy](https://togithub.com/tioxy) in [kubernetes-sigs/descheduler#1349 - Fix node taint wrong EvictOption field by [@​tioxy](https://togithub.com/tioxy) in [kubernetes-sigs/descheduler#1358 - Disambiguate node fit log messages by [@​jackfrancis](https://togithub.com/jackfrancis) in [kubernetes-sigs/descheduler#1362 - Check whether pod matches the inter-pod anti-affinity of another Pod in a given Node in `NodeFit()` by [@​nikimanoledaki](https://togithub.com/nikimanoledaki) in [kubernetes-sigs/descheduler#1356 - Bump to k8s v0.30.0-alpha.3 by [@​pravarag](https://togithub.com/pravarag) in [kubernetes-sigs/descheduler#1359 - skip eviction when replica count is below evictor `minReplicas` threshold setting by [@​a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1257 - Add argument to remove only pods violating allowlisted taints by [@​etoster](https://togithub.com/etoster) in [kubernetes-sigs/descheduler#1360 - use v1alpha2 api for helm chart default values by [@​a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1139 - `RemoveDuplicates`: reduce cycle times identifying duplicates by [@​ls-2018](https://togithub.com/ls-2018) in [kubernetes-sigs/descheduler#1365 - avoid redundant type conversion of DefaultEvictorArgs parameter in DefaultEvictor by [@​fanhaouu](https://togithub.com/fanhaouu) in [kubernetes-sigs/descheduler#1369 - bump(golang.org/x/net)=v0.23.0 by [@​ingvagabund](https://togithub.com/ingvagabund) in [kubernetes-sigs/descheduler#1373 - Allow eviction of DaemonSet pods by [@​tioxy](https://togithub.com/tioxy) in [kubernetes-sigs/descheduler#1342 - bump to go 1.22.2 by [@​jklaw90](https://togithub.com/jklaw90) in [kubernetes-sigs/descheduler#1374 - helm: Allow the use of existing policy configMap by [@​agmimidi](https://togithub.com/agmimidi) in [kubernetes-sigs/descheduler#1376 - Fix and improve the namespace filtering description in README by [@​yuanchen8911](https://togithub.com/yuanchen8911) in [kubernetes-sigs/descheduler#1379 - Add an extra parameter ExitCode to RemoveFailedPods by [@​yuanchen8911](https://togithub.com/yuanchen8911) in [kubernetes-sigs/descheduler#1381 - 753 - Descheduling framework by [@​ingvagabund](https://togithub.com/ingvagabund) in [kubernetes-sigs/descheduler#1372 - KEP-753: Descheduling framework: update diagram by [@​ingvagabund](https://togithub.com/ingvagabund) in [kubernetes-sigs/descheduler#1396 - \[release 1.30] upgrade kubernetes version and docs by [@​a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1400 #### New Contributors - [@​xujihui1985](https://togithub.com/xujihui1985) made their first contribution in [kubernetes-sigs/descheduler#1334 - [@​UAntBou](https://togithub.com/UAntBou) made their first contribution in [kubernetes-sigs/descheduler#1289 - [@​tioxy](https://togithub.com/tioxy) made their first contribution in [kubernetes-sigs/descheduler#1349 - [@​jackfrancis](https://togithub.com/jackfrancis) made their first contribution in [kubernetes-sigs/descheduler#1362 - [@​nikimanoledaki](https://togithub.com/nikimanoledaki) made their first contribution in [kubernetes-sigs/descheduler#1356 - [@​etoster](https://togithub.com/etoster) made their first contribution in [kubernetes-sigs/descheduler#1360 - [@​ls-2018](https://togithub.com/ls-2018) made their first contribution in [kubernetes-sigs/descheduler#1365 - [@​fanhaouu](https://togithub.com/fanhaouu) made their first contribution in [kubernetes-sigs/descheduler#1369 - [@​agmimidi](https://togithub.com/agmimidi) made their first contribution in [kubernetes-sigs/descheduler#1376 - [@​yuanchen8911](https://togithub.com/yuanchen8911) made their first contribution in [kubernetes-sigs/descheduler#1379 **Full Changelog**: kubernetes-sigs/descheduler@v0.29.0...v0.30.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNjguOSIsInVwZGF0ZWRJblZlciI6IjM3LjM2OC45IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9oZWxtIiwidHlwZS9taW5vciJdfQ==-->
This PR contains the following updates: | Package | Update | Change | |---|---|---| | [descheduler](https://togithub.com/kubernetes-sigs/descheduler) | minor | `0.29.0` -> `0.30.0` | --- ### Release Notes <details> <summary>kubernetes-sigs/descheduler (descheduler)</summary> ### [`v0.30.0`](https://togithub.com/kubernetes-sigs/descheduler/releases/tag/v0.30.0): Descheduler v0.30.0 [Compare Source](https://togithub.com/kubernetes-sigs/descheduler/compare/v0.29.0...v0.30.0) #### What's Changed - fix(podlifetime): fix failed unittest by [@​xujihui1985](https://togithub.com/xujihui1985) in [kubernetes-sigs/descheduler#1334 - `PodLifeTime`: update support pods with container status and pods reason by [@​dongjiang1989](https://togithub.com/dongjiang1989) in [kubernetes-sigs/descheduler#1330 - v1alpha1: log deprecation notice by [@​a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1337 - feat: Add support for topologySpreadConstraints by [@​UAntBou](https://togithub.com/UAntBou) in [kubernetes-sigs/descheduler#1289 - chore: update dependencies for security vulnerabilities (CVE-2023-48795) by [@​a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1343 - trim managedFields in shared informer factory by [@​a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1346 - fix: `RemovePodsHavingTooManyRestarts` to include `InitContainerStatuses` by [@​a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1348 - Improve PodEvictor observability through EvictOptions by [@​tioxy](https://togithub.com/tioxy) in [kubernetes-sigs/descheduler#1349 - Fix node taint wrong EvictOption field by [@​tioxy](https://togithub.com/tioxy) in [kubernetes-sigs/descheduler#1358 - Disambiguate node fit log messages by [@​jackfrancis](https://togithub.com/jackfrancis) in [kubernetes-sigs/descheduler#1362 - Check whether pod matches the inter-pod anti-affinity of another Pod in a given Node in `NodeFit()` by [@​nikimanoledaki](https://togithub.com/nikimanoledaki) in [kubernetes-sigs/descheduler#1356 - Bump to k8s v0.30.0-alpha.3 by [@​pravarag](https://togithub.com/pravarag) in [kubernetes-sigs/descheduler#1359 - skip eviction when replica count is below evictor `minReplicas` threshold setting by [@​a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1257 - Add argument to remove only pods violating allowlisted taints by [@​etoster](https://togithub.com/etoster) in [kubernetes-sigs/descheduler#1360 - use v1alpha2 api for helm chart default values by [@​a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1139 - `RemoveDuplicates`: reduce cycle times identifying duplicates by [@​ls-2018](https://togithub.com/ls-2018) in [kubernetes-sigs/descheduler#1365 - avoid redundant type conversion of DefaultEvictorArgs parameter in DefaultEvictor by [@​fanhaouu](https://togithub.com/fanhaouu) in [kubernetes-sigs/descheduler#1369 - bump(golang.org/x/net)=v0.23.0 by [@​ingvagabund](https://togithub.com/ingvagabund) in [kubernetes-sigs/descheduler#1373 - Allow eviction of DaemonSet pods by [@​tioxy](https://togithub.com/tioxy) in [kubernetes-sigs/descheduler#1342 - bump to go 1.22.2 by [@​jklaw90](https://togithub.com/jklaw90) in [kubernetes-sigs/descheduler#1374 - helm: Allow the use of existing policy configMap by [@​agmimidi](https://togithub.com/agmimidi) in [kubernetes-sigs/descheduler#1376 - Fix and improve the namespace filtering description in README by [@​yuanchen8911](https://togithub.com/yuanchen8911) in [kubernetes-sigs/descheduler#1379 - Add an extra parameter ExitCode to RemoveFailedPods by [@​yuanchen8911](https://togithub.com/yuanchen8911) in [kubernetes-sigs/descheduler#1381 - 753 - Descheduling framework by [@​ingvagabund](https://togithub.com/ingvagabund) in [kubernetes-sigs/descheduler#1372 - KEP-753: Descheduling framework: update diagram by [@​ingvagabund](https://togithub.com/ingvagabund) in [kubernetes-sigs/descheduler#1396 - \[release 1.30] upgrade kubernetes version and docs by [@​a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1400 #### New Contributors - [@​xujihui1985](https://togithub.com/xujihui1985) made their first contribution in [kubernetes-sigs/descheduler#1334 - [@​UAntBou](https://togithub.com/UAntBou) made their first contribution in [kubernetes-sigs/descheduler#1289 - [@​tioxy](https://togithub.com/tioxy) made their first contribution in [kubernetes-sigs/descheduler#1349 - [@​jackfrancis](https://togithub.com/jackfrancis) made their first contribution in [kubernetes-sigs/descheduler#1362 - [@​nikimanoledaki](https://togithub.com/nikimanoledaki) made their first contribution in [kubernetes-sigs/descheduler#1356 - [@​etoster](https://togithub.com/etoster) made their first contribution in [kubernetes-sigs/descheduler#1360 - [@​ls-2018](https://togithub.com/ls-2018) made their first contribution in [kubernetes-sigs/descheduler#1365 - [@​fanhaouu](https://togithub.com/fanhaouu) made their first contribution in [kubernetes-sigs/descheduler#1369 - [@​agmimidi](https://togithub.com/agmimidi) made their first contribution in [kubernetes-sigs/descheduler#1376 - [@​yuanchen8911](https://togithub.com/yuanchen8911) made their first contribution in [kubernetes-sigs/descheduler#1379 **Full Changelog**: kubernetes-sigs/descheduler@v0.29.0...v0.30.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNjguOSIsInVwZGF0ZWRJblZlciI6IjM3LjM2OC45IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9oZWxtIiwidHlwZS9taW5vciJdfQ==--> Co-authored-by: kireque-bot[bot] <143391978+kireque-bot[bot]@users.noreply.github.com>
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [descheduler](https://togithub.com/kubernetes-sigs/descheduler) | minor | `0.29.0` -> `0.30.1` | --- ### Release Notes <details> <summary>kubernetes-sigs/descheduler (descheduler)</summary> ### [`v0.30.1`](https://togithub.com/kubernetes-sigs/descheduler/compare/v0.30.0...v0.30.1) [Compare Source](https://togithub.com/kubernetes-sigs/descheduler/compare/v0.30.0...v0.30.1) ### [`v0.30.0`](https://togithub.com/kubernetes-sigs/descheduler/releases/tag/v0.30.0): Descheduler v0.30.0 [Compare Source](https://togithub.com/kubernetes-sigs/descheduler/compare/v0.29.0...v0.30.0) #### What's Changed - fix(podlifetime): fix failed unittest by [@​xujihui1985](https://togithub.com/xujihui1985) in [kubernetes-sigs/descheduler#1334 - `PodLifeTime`: update support pods with container status and pods reason by [@​dongjiang1989](https://togithub.com/dongjiang1989) in [kubernetes-sigs/descheduler#1330 - v1alpha1: log deprecation notice by [@​a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1337 - feat: Add support for topologySpreadConstraints by [@​UAntBou](https://togithub.com/UAntBou) in [kubernetes-sigs/descheduler#1289 - chore: update dependencies for security vulnerabilities (CVE-2023-48795) by [@​a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1343 - trim managedFields in shared informer factory by [@​a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1346 - fix: `RemovePodsHavingTooManyRestarts` to include `InitContainerStatuses` by [@​a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1348 - Improve PodEvictor observability through EvictOptions by [@​tioxy](https://togithub.com/tioxy) in [kubernetes-sigs/descheduler#1349 - Fix node taint wrong EvictOption field by [@​tioxy](https://togithub.com/tioxy) in [kubernetes-sigs/descheduler#1358 - Disambiguate node fit log messages by [@​jackfrancis](https://togithub.com/jackfrancis) in [kubernetes-sigs/descheduler#1362 - Check whether pod matches the inter-pod anti-affinity of another Pod in a given Node in `NodeFit()` by [@​nikimanoledaki](https://togithub.com/nikimanoledaki) in [kubernetes-sigs/descheduler#1356 - Bump to k8s v0.30.0-alpha.3 by [@​pravarag](https://togithub.com/pravarag) in [kubernetes-sigs/descheduler#1359 - skip eviction when replica count is below evictor `minReplicas` threshold setting by [@​a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1257 - Add argument to remove only pods violating allowlisted taints by [@​etoster](https://togithub.com/etoster) in [kubernetes-sigs/descheduler#1360 - use v1alpha2 api for helm chart default values by [@​a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1139 - `RemoveDuplicates`: reduce cycle times identifying duplicates by [@​ls-2018](https://togithub.com/ls-2018) in [kubernetes-sigs/descheduler#1365 - avoid redundant type conversion of DefaultEvictorArgs parameter in DefaultEvictor by [@​fanhaouu](https://togithub.com/fanhaouu) in [kubernetes-sigs/descheduler#1369 - bump(golang.org/x/net)=v0.23.0 by [@​ingvagabund](https://togithub.com/ingvagabund) in [kubernetes-sigs/descheduler#1373 - Allow eviction of DaemonSet pods by [@​tioxy](https://togithub.com/tioxy) in [kubernetes-sigs/descheduler#1342 - bump to go 1.22.2 by [@​jklaw90](https://togithub.com/jklaw90) in [kubernetes-sigs/descheduler#1374 - helm: Allow the use of existing policy configMap by [@​agmimidi](https://togithub.com/agmimidi) in [kubernetes-sigs/descheduler#1376 - Fix and improve the namespace filtering description in README by [@​yuanchen8911](https://togithub.com/yuanchen8911) in [kubernetes-sigs/descheduler#1379 - Add an extra parameter ExitCode to RemoveFailedPods by [@​yuanchen8911](https://togithub.com/yuanchen8911) in [kubernetes-sigs/descheduler#1381 - 753 - Descheduling framework by [@​ingvagabund](https://togithub.com/ingvagabund) in [kubernetes-sigs/descheduler#1372 - KEP-753: Descheduling framework: update diagram by [@​ingvagabund](https://togithub.com/ingvagabund) in [kubernetes-sigs/descheduler#1396 - \[release 1.30] upgrade kubernetes version and docs by [@​a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1400 #### New Contributors - [@​xujihui1985](https://togithub.com/xujihui1985) made their first contribution in [kubernetes-sigs/descheduler#1334 - [@​UAntBou](https://togithub.com/UAntBou) made their first contribution in [kubernetes-sigs/descheduler#1289 - [@​tioxy](https://togithub.com/tioxy) made their first contribution in [kubernetes-sigs/descheduler#1349 - [@​jackfrancis](https://togithub.com/jackfrancis) made their first contribution in [kubernetes-sigs/descheduler#1362 - [@​nikimanoledaki](https://togithub.com/nikimanoledaki) made their first contribution in [kubernetes-sigs/descheduler#1356 - [@​etoster](https://togithub.com/etoster) made their first contribution in [kubernetes-sigs/descheduler#1360 - [@​ls-2018](https://togithub.com/ls-2018) made their first contribution in [kubernetes-sigs/descheduler#1365 - [@​fanhaouu](https://togithub.com/fanhaouu) made their first contribution in [kubernetes-sigs/descheduler#1369 - [@​agmimidi](https://togithub.com/agmimidi) made their first contribution in [kubernetes-sigs/descheduler#1376 - [@​yuanchen8911](https://togithub.com/yuanchen8911) made their first contribution in [kubernetes-sigs/descheduler#1379 **Full Changelog**: kubernetes-sigs/descheduler@v0.29.0...v0.30.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on saturday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/sp3nx0r/homelab). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNjguMTAiLCJ1cGRhdGVkSW5WZXIiOiIzNy4zODguMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsicmVub3ZhdGUvaGVsbSIsInR5cGUvbWlub3IiXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
…0.30.x (#1015) [![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [descheduler](https://togithub.com/kubernetes-sigs/descheduler) | minor | `0.29.x` -> `0.30.x` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>kubernetes-sigs/descheduler (descheduler)</summary> ### [`v0.30.1`](https://togithub.com/kubernetes-sigs/descheduler/releases/tag/v0.30.1): Descheduler v0.30.1 [Compare Source](https://togithub.com/kubernetes-sigs/descheduler/compare/v0.30.0...v0.30.1) #### What's Changed - bump to to 1.22.3 to address CVE-2024-24788 by [@​a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1408 - \[release 1.30] update kustomize image tags and helm versions by [@​a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1405 - Automated cherry pick of [#​1378](https://togithub.com/kubernetes-sigs/descheduler/issues/1378): Fix the replicas type for the helm-chart [#​1390](https://togithub.com/kubernetes-sigs/descheduler/issues/1390): allow 'falsey' value in cmdOption [#​1412](https://togithub.com/kubernetes-sigs/descheduler/issues/1412): fix helm's default deschedulerPolicy [#​1413](https://togithub.com/kubernetes-sigs/descheduler/issues/1413): fix TOC location in Readme [#​1416](https://togithub.com/kubernetes-sigs/descheduler/issues/1416): use cmd context instead of using context.Background() [#​1395](https://togithub.com/kubernetes-sigs/descheduler/issues/1395): fix the issue that the pod anti-filtering rules are not by [@​a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1425 **Full Changelog**: kubernetes-sigs/descheduler@v0.30.0...v0.30.1 ### [`v0.30.0`](https://togithub.com/kubernetes-sigs/descheduler/releases/tag/v0.30.0): Descheduler v0.30.0 [Compare Source](https://togithub.com/kubernetes-sigs/descheduler/compare/v0.29.0...v0.30.0) #### What's Changed - fix(podlifetime): fix failed unittest by [@​xujihui1985](https://togithub.com/xujihui1985) in [kubernetes-sigs/descheduler#1334 - `PodLifeTime`: update support pods with container status and pods reason by [@​dongjiang1989](https://togithub.com/dongjiang1989) in [kubernetes-sigs/descheduler#1330 - v1alpha1: log deprecation notice by [@​a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1337 - feat: Add support for topologySpreadConstraints by [@​UAntBou](https://togithub.com/UAntBou) in [kubernetes-sigs/descheduler#1289 - chore: update dependencies for security vulnerabilities (CVE-2023-48795) by [@​a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1343 - trim managedFields in shared informer factory by [@​a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1346 - fix: `RemovePodsHavingTooManyRestarts` to include `InitContainerStatuses` by [@​a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1348 - Improve PodEvictor observability through EvictOptions by [@​tioxy](https://togithub.com/tioxy) in [kubernetes-sigs/descheduler#1349 - Fix node taint wrong EvictOption field by [@​tioxy](https://togithub.com/tioxy) in [kubernetes-sigs/descheduler#1358 - Disambiguate node fit log messages by [@​jackfrancis](https://togithub.com/jackfrancis) in [kubernetes-sigs/descheduler#1362 - Check whether pod matches the inter-pod anti-affinity of another Pod in a given Node in `NodeFit()` by [@​nikimanoledaki](https://togithub.com/nikimanoledaki) in [kubernetes-sigs/descheduler#1356 - Bump to k8s v0.30.0-alpha.3 by [@​pravarag](https://togithub.com/pravarag) in [kubernetes-sigs/descheduler#1359 - skip eviction when replica count is below evictor `minReplicas` threshold setting by [@​a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1257 - Add argument to remove only pods violating allowlisted taints by [@​etoster](https://togithub.com/etoster) in [kubernetes-sigs/descheduler#1360 - use v1alpha2 api for helm chart default values by [@​a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1139 - `RemoveDuplicates`: reduce cycle times identifying duplicates by [@​ls-2018](https://togithub.com/ls-2018) in [kubernetes-sigs/descheduler#1365 - avoid redundant type conversion of DefaultEvictorArgs parameter in DefaultEvictor by [@​fanhaouu](https://togithub.com/fanhaouu) in [kubernetes-sigs/descheduler#1369 - bump(golang.org/x/net)=v0.23.0 by [@​ingvagabund](https://togithub.com/ingvagabund) in [kubernetes-sigs/descheduler#1373 - Allow eviction of DaemonSet pods by [@​tioxy](https://togithub.com/tioxy) in [kubernetes-sigs/descheduler#1342 - bump to go 1.22.2 by [@​jklaw90](https://togithub.com/jklaw90) in [kubernetes-sigs/descheduler#1374 - helm: Allow the use of existing policy configMap by [@​agmimidi](https://togithub.com/agmimidi) in [kubernetes-sigs/descheduler#1376 - Fix and improve the namespace filtering description in README by [@​yuanchen8911](https://togithub.com/yuanchen8911) in [kubernetes-sigs/descheduler#1379 - Add an extra parameter ExitCode to RemoveFailedPods by [@​yuanchen8911](https://togithub.com/yuanchen8911) in [kubernetes-sigs/descheduler#1381 - 753 - Descheduling framework by [@​ingvagabund](https://togithub.com/ingvagabund) in [kubernetes-sigs/descheduler#1372 - KEP-753: Descheduling framework: update diagram by [@​ingvagabund](https://togithub.com/ingvagabund) in [kubernetes-sigs/descheduler#1396 - \[release 1.30] upgrade kubernetes version and docs by [@​a7i](https://togithub.com/a7i) in [kubernetes-sigs/descheduler#1400 #### New Contributors - [@​xujihui1985](https://togithub.com/xujihui1985) made their first contribution in [kubernetes-sigs/descheduler#1334 - [@​UAntBou](https://togithub.com/UAntBou) made their first contribution in [kubernetes-sigs/descheduler#1289 - [@​tioxy](https://togithub.com/tioxy) made their first contribution in [kubernetes-sigs/descheduler#1349 - [@​jackfrancis](https://togithub.com/jackfrancis) made their first contribution in [kubernetes-sigs/descheduler#1362 - [@​nikimanoledaki](https://togithub.com/nikimanoledaki) made their first contribution in [kubernetes-sigs/descheduler#1356 - [@​etoster](https://togithub.com/etoster) made their first contribution in [kubernetes-sigs/descheduler#1360 - [@​ls-2018](https://togithub.com/ls-2018) made their first contribution in [kubernetes-sigs/descheduler#1365 - [@​fanhaouu](https://togithub.com/fanhaouu) made their first contribution in [kubernetes-sigs/descheduler#1369 - [@​agmimidi](https://togithub.com/agmimidi) made their first contribution in [kubernetes-sigs/descheduler#1376 - [@​yuanchen8911](https://togithub.com/yuanchen8911) made their first contribution in [kubernetes-sigs/descheduler#1379 **Full Changelog**: kubernetes-sigs/descheduler@v0.29.0...v0.30.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/teutonet/teutonet-helm-charts). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjEuOSIsInVwZGF0ZWRJblZlciI6IjM3LjQyMS45IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
correct desired pod creation time
"Two pods in the
dev
Namespace, 1 created 605 seconds ago. 1 should be evicted.", the create time stamp should be 605 s before current time