Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ryan as an owner of the cluster api repo #4

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

ryanzhang-oss
Copy link
Contributor

No description provided.

Copy link

linux-foundation-easycla bot commented Mar 13, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: ryanzhang-oss / name: Ryan Zhang (8125739)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Mar 13, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @ryanzhang-oss!

It looks like this is your first PR to kubernetes-sigs/cluster-inventory-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-inventory-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 13, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 13, 2024
@ryanzhang-oss
Copy link
Contributor Author

/verify-owners

@k8s-ci-robot
Copy link
Contributor

The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the kubernetes-sigs org. You can then trigger verification by writing /verify-owners in a comment.

  • ryanzhang-oss
    • User is not a member of the org. Satisfy at least one of these conditions to make the user trusted.

@mikeshng
Copy link
Member

/approve

/lgtm

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 13, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dixudx, mikeshng, ryanzhang-oss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dixudx dixudx removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Mar 14, 2024
@dixudx dixudx merged commit f93cce9 into kubernetes-sigs:main Mar 14, 2024
2 checks passed
@RainbowMango
Copy link
Member

/lgtm

ryanzhang-oss
User is not a member of the org. Satisfy at least one of these conditions to make the user trusted.

I see @dixudx removed the do-not-merge/invalid-owners-file label, just out of curiosity, what would happen if an owner is not org member?

@dixudx
Copy link
Member

dixudx commented Mar 14, 2024

@RainbowMango Ryan(ryanzhang-oss) is an org member, please refer to kubernetes/org#4816.

@dixudx
Copy link
Member

dixudx commented Mar 14, 2024

/verify-owners

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants