Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Clarify rules for adding new clusterctl default providers #9975

Merged
merged 3 commits into from
Jan 22, 2024
Merged

🌱 Clarify rules for adding new clusterctl default providers #9975

merged 3 commits into from
Jan 22, 2024

Conversation

fabriziopandini
Copy link
Member

What this PR does / why we need it:
This PR is a follow-up to the discussion in #9869, to avoid similar cases from happening again in the future.

/area clusterctl

@k8s-ci-robot k8s-ci-robot added area/clusterctl Issues or PRs related to clusterctl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 10, 2024
@fabriziopandini
Copy link
Member Author

/hold
for discussion at the next office hours

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 10, 2024
sbueringer
sbueringer reviewed Jan 11, 2024
View reviewed changes
Copy link
Member

@sbueringer sbueringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nits, otherwise lgtm

docs/book/src/clusterctl/provider-contract.md Outdated Show resolved Hide resolved
docs/book/src/clusterctl/provider-contract.md Outdated Show resolved Hide resolved
docs/book/src/clusterctl/provider-contract.md Outdated Show resolved Hide resolved
docs/book/src/clusterctl/provider-contract.md Outdated Show resolved Hide resolved
@chrischdi chrischdi mentioned this pull request Jan 12, 2024
Merged
@sbueringer
Copy link
Member

Thx!

/lgtm

Maybe also lazy consensus until next week Friday?
(as it was brought up in office hours this week already)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 12, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 22dcee0e270786af0a504385b902b68968cd7478

@sbueringer
Copy link
Member

/assign @enxebre @vincepri @killianmuldoon @CecileRobertMichon

vincepri
vincepri reviewed Jan 12, 2024
View reviewed changes
docs/book/src/clusterctl/commands/init.md Outdated Show resolved Hide resolved
docs/book/src/clusterctl/provider-contract.md
- The name must consist of lower case alphanumeric characters or '-', and must start and end with an alphanumeric character.
- The name length should not exceed 63 characters.
- For providers not in the kubernetes-sigs org, in order to prevent conflicts the `clusterctl` name must be prefixed with
the provider's GitHub org name followed by `-` (see note below).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not a /?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because those names are used for the provider resource inside Kubernetes, and / is not a valid character.

docs/book/src/clusterctl/provider-contract.md Show resolved Hide resolved
@fabriziopandini
Copy link
Member Author

fabriziopandini commented Jan 17, 2024 •
edited
Loading

As per 17th Jan office hour discussion we are merging this PR ASAP (I still have to address nits first) and then open a mail thread to discuss the idea suggested by @vincepri in #9975 (comment)

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 19, 2024
@fabriziopandini
Copy link
Member Author

This PR should be ready to go now
cc @sbueringer @vincepri

@sbueringer
Copy link
Member

Thx!

/lgtm
/assign @vincepri

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 22, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 02b9511ed8c42172b6ccffa89e6caa980e4dc624

@sbueringer
Copy link
Member

Let's merge it to unblock #9991. We can iterate if necessary

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2024
killianmuldoon
killianmuldoon reviewed Jan 22, 2024
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

/hold cancel

Thanks for updating this - the new policy definitely makes sense.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 22, 2024
@killianmuldoon
Copy link
Contributor

/hold

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: killianmuldoon, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 22, 2024
@killianmuldoon
Copy link
Contributor

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 22, 2024
@k8s-ci-robot k8s-ci-robot merged commit 23bdaa4 into kubernetes-sigs:main Jan 22, 2024
19 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.7 milestone Jan 22, 2024
@fabriziopandini fabriziopandini deleted the clarify-rules-for-clusterctl-default-providers branch January 23, 2024 09:38
@fabriziopandini
Copy link
Member Author

/cherry-pick release-1.6

@k8s-infra-cherrypick-robot
Copy link

@fabriziopandini: new pull request created: #10109

In response to this:

/cherry-pick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Feb 6, 2024
Merged
@fabriziopandini fabriziopandini mentioned this pull request Feb 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killianmuldoon killianmuldoon killianmuldoon left review comments

@chrischdi chrischdi Awaiting requested review from chrischdi

@stmcginnis stmcginnis Awaiting requested review from stmcginnis

@CecileRobertMichon CecileRobertMichon Awaiting requested review from CecileRobertMichon

@enxebre enxebre Awaiting requested review from enxebre

@sbueringer sbueringer Awaiting requested review from sbueringer

@vincepri vincepri Awaiting requested review from vincepri

Assignees

@enxebre enxebre

@vincepri vincepri

@sbueringer sbueringer

@CecileRobertMichon CecileRobertMichon

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/clusterctl Issues or PRs related to clusterctl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@fabriziopandini @sbueringer @k8s-ci-robot @killianmuldoon @k8s-infra-cherrypick-robot @vincepri @enxebre @CecileRobertMichon