Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 ipam: fix webhooks using mixed api versions #9861

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

schrej
Copy link
Member

@schrej schrej commented Dec 12, 2023

What this PR does / why we need it:
During the bump of IPAM resources to v1beta1 the version in the kubebuilder:webhook comment was missed which leads to a 'resource not found' error when they are called by the apiserver.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #9860

/area ipam

@k8s-ci-robot k8s-ci-robot added area/ipam Issues or PRs related to ipam cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 12, 2023
@sbueringer
Copy link
Member

Thx nice catch.

Risk of having no test coverage in core CAPI I guess :/

/lgtm
/approve

/cherry-pick release-1.6

@k8s-infra-cherrypick-robot

@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.6 in a new PR and assign it to you.

In response to this:

Thx nice catch.

Risk of having no test coverage in core CAPI I guess :/

/lgtm
/approve

/cherry-pick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 12, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d86f90582b7d3719cee517bf855a4db92e646468

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2023
@k8s-ci-robot k8s-ci-robot merged commit 9cea647 into kubernetes-sigs:main Dec 12, 2023
22 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.7 milestone Dec 12, 2023
@k8s-infra-cherrypick-robot

@sbueringer: new pull request created: #9863

In response to this:

Thx nice catch.

Risk of having no test coverage in core CAPI I guess :/

/lgtm
/approve

/cherry-pick release-1.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ipam Issues or PRs related to ipam cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IPAM webhooks are not working
4 participants