⚠️ Objects generated by KCP, MachineSets and MachinePools will now consistently use machine name #9833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
sbueringer
added
area/provider/control-plane-kubeadm
|
/assign @fabriziopandini @enxebre @chrischdi |
sbueringer
force-pushed
the
pr-same-names
branch
3 times, most recently
from
76bb6da
to
0e8bc16
Compare
|
/test pull-cluster-api-e2e-full-main |
sbueringer
force-pushed
the
pr-same-names
branch
from
0e8bc16
to
849db80
Compare
sbueringer
changed the title
|
/test pull-cluster-api-e2e-full-main |
|
Small improvement nit. As of that |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 5534221d993ba9ec69fbefd0470773086ee45cf8
|
chrischdi
reviewed
Dec 12, 2023
sbueringer
force-pushed
the
pr-same-names
branch
from
849db80
to
7fefd78
Compare
k8s-ci-robot
removed
the
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 1457714298633f883ebb3d485f72cc8e91b71bd5
|
|
/assign @killianmuldoon If you have some time |
k8s-ci-robot
added
the
needs-rebase
Signed-off-by: Stefan Büringer [email protected]
sbueringer
force-pushed
the
pr-same-names
branch
from
7fefd78
to
8d62deb
Compare
k8s-ci-robot
removed
the
lgtm
k8s-ci-robot
removed
the
needs-rebase
|
Rebased /assign @chrischdi @fabriziopandini |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 8b42b6e9dc5ad4c25fbb8829b29420105cdc773b
|
|
/lgtm Thanks! Name consistency will greatly improve triaging and investigating issues, as well as navigating the CAPI object hierarchy |
|
Changed the title to bubble this up in the release note |
fabriziopandini
changed the title
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enxebre The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
sbueringer
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stefan Büringer [email protected]
What this PR does / why we need it:
(Compared to the issue) I also implemented it for MachinePool Machines. There is nothing we can do about BootstrapConfig there because it belongs to the MachinePool not to individual Machines, but at least Machines and InfraMachines now have the same name.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #9733