📖 Update MachinePool Machines proposal with diagrams #9664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
area/machinepool
Jont828
force-pushed
the
mpm-proposal-update
branch
from
f071814
to
4c484ee
Compare
docs/proposals/images/machinepool-machines/inframachinepool-delete-replicas.plantuml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Thank you for updating the proposal @Jont828. Most of my comments are around the diagrams, I'm having a hard time following what each box is referring to even though I;m familiar with the code implementation so I could see this being even more confusing to a newcomer. Consider adding actors so it's clear who is doing what as @shyamradhakrishnan suggested, and keeping the text boxes action-oriented
docs/proposals/images/machinepool-machines/inframachinepool-create-replicas.plantuml
Outdated
Show resolved
Hide resolved
docs/proposals/images/machinepool-machines/inframachinepool-create-replicas.plantuml
Outdated
Show resolved
Hide resolved
docs/proposals/images/machinepool-machines/inframachinepool-create-replicas.plantuml
Outdated
Show resolved
Hide resolved
docs/proposals/images/machinepool-machines/inframachinepool-create-replicas.plantuml
Outdated
Show resolved
Hide resolved
docs/proposals/images/machinepool-machines/inframachinepool-delete-replicas.plantuml
Outdated
Show resolved
Hide resolved
docs/proposals/images/machinepool-machines/inframachinepool-delete-replicas.plantuml
Outdated
Show resolved
Hide resolved
docs/proposals/images/machinepool-machines/inframachinepool-delete-replicas.plantuml
Outdated
Show resolved
Hide resolved
docs/proposals/images/machinepool-machines/machinepool-machines-reconcile.plantuml
Outdated
Show resolved
Hide resolved
docs/proposals/images/machinepool-machines/machinepool-machines-reconcile.plantuml
Outdated
Show resolved
Hide resolved
Jont828
force-pushed
the
mpm-proposal-update
branch
from
b604148
to
fc06ff8
Compare
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: dc3083d567901919b93ec3b8bbd518fc9a2cead3
|
Jont828
force-pushed
the
mpm-proposal-update
branch
from
756ae30
to
711ed35
Compare
|
@CecileRobertMichon Done! |
|
there are broken link errors, PTAL |
Jont828
force-pushed
the
mpm-proposal-update
branch
from
711ed35
to
de70714
Compare
k8s-ci-robot
removed
the
lgtm
k8s-ci-robot
requested review from
CecileRobertMichon,
fabriziopandini,
mboersma and
shyamradhakrishnan
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 49904257b63b9259a6e9250f7337da965d1a9874
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Updates the MachinePool Machines proposal to reflect the work in #8828, #8842, #9619, and
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
/area machinepool