Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.7] 🌱 Support MachinePools without MachinePoolMachines in clusterctl upgrade test #10614

Conversation

willie-yao
Copy link
Contributor

What this PR does / why we need it:
This PR is a manual cherry-pick of #10498 and #10584

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

/area testing

@k8s-ci-robot k8s-ci-robot added this to the v1.7 milestone May 14, 2024
@k8s-ci-robot k8s-ci-robot added area/testing Issues or PRs related to testing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 14, 2024
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 14, 2024
@willie-yao
Copy link
Contributor Author

/test pull-cluster-api-e2e-release-1.7

@k8s-ci-robot
Copy link
Contributor

@willie-yao: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-cluster-api-build-release-1-7
  • /test pull-cluster-api-e2e-blocking-release-1-7
  • /test pull-cluster-api-e2e-conformance-ci-latest-release-1-7
  • /test pull-cluster-api-e2e-conformance-release-1-7
  • /test pull-cluster-api-e2e-mink8s-release-1-7
  • /test pull-cluster-api-e2e-release-1-7
  • /test pull-cluster-api-e2e-upgrade-1-29-1-30-release-1-7
  • /test pull-cluster-api-test-mink8s-release-1-7
  • /test pull-cluster-api-test-release-1-7
  • /test pull-cluster-api-verify-release-1-7

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-apidiff-release-1-7

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-apidiff-release-1-7
  • pull-cluster-api-build-release-1-7
  • pull-cluster-api-e2e-blocking-release-1-7
  • pull-cluster-api-test-release-1-7
  • pull-cluster-api-verify-release-1-7

In response to this:

/test pull-cluster-api-e2e-release-1.7

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@willie-yao
Copy link
Contributor Author

/test pull-cluster-api-e2e-release-1-7

@willie-yao
Copy link
Contributor Author

/retest

1 similar comment
@willie-yao
Copy link
Contributor Author

/retest

@willie-yao
Copy link
Contributor Author

/assign @sbueringer

@sbueringer
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 15, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e2a1409839db116ca9f4609f8925c6b99f98d237

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 15, 2024
@k8s-ci-robot k8s-ci-robot merged commit 48c3925 into kubernetes-sigs:release-1.7 May 15, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/testing Issues or PRs related to testing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants