Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.7] 🐛 clusterctl: ensure cert-manager objects get applied before other provider objects #10503

Merged
merged 1 commit into from
Apr 24, 2024
Merged

[release-1.7] 🐛 clusterctl: ensure cert-manager objects get applied before other provider objects #10503

merged 1 commit into from
Apr 24, 2024

Conversation

k8s-infra-cherrypick-robot
Copy link

This is an automated cherry-pick of #10469

/assign chrischdi

@chrischdi
apply cert-manager objects in clusterctl before other provider object…
192eb87 
…s and wait for ca injection in tests using a clusterctl binary
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Apr 24, 2024
Merged
@k8s-ci-robot k8s-ci-robot added this to the v1.7 milestone Apr 24, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 24, 2024
@chrischdi
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 24, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6376a07753450d1c25695d911ac91c698daf11d4

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2024
@chrischdi
Copy link
Member

/test help

@k8s-ci-robot
Copy link
Contributor

@chrischdi: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-cluster-api-build-release-1-7
  • /test pull-cluster-api-e2e-blocking-release-1-7
  • /test pull-cluster-api-e2e-conformance-ci-latest-release-1-7
  • /test pull-cluster-api-e2e-conformance-release-1-7
  • /test pull-cluster-api-e2e-dualstack-and-ipv6-release-1-7
  • /test pull-cluster-api-e2e-mink8s-release-1-7
  • /test pull-cluster-api-e2e-release-1-7
  • /test pull-cluster-api-e2e-upgrade-1-29-1-30-release-1-7
  • /test pull-cluster-api-test-mink8s-release-1-7
  • /test pull-cluster-api-test-release-1-7
  • /test pull-cluster-api-verify-release-1-7

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-apidiff-release-1-7

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-apidiff-release-1-7
  • pull-cluster-api-build-release-1-7
  • pull-cluster-api-e2e-blocking-release-1-7
  • pull-cluster-api-test-release-1-7
  • pull-cluster-api-verify-release-1-7

In response to this:

/test help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chrischdi
Copy link
Member

/test pull-cluster-api-e2e-release-1-7

@chrischdi
Copy link
Member

/area clusterctl

@k8s-ci-robot k8s-ci-robot added area/clusterctl Issues or PRs related to clusterctl and removed do-not-merge/needs-area PR is missing an area label labels Apr 24, 2024
@sbueringer
Copy link
Member

/lgtm

@sbueringer
Copy link
Member

/retest

@k8s-ci-robot k8s-ci-robot merged commit 1cc294a into kubernetes-sigs:release-1.7 Apr 24, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@richardcase richardcase Awaiting requested review from richardcase

Assignees

@chrischdi chrischdi

@sbueringer sbueringer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/clusterctl Issues or PRs related to clusterctl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@k8s-infra-cherrypick-robot @chrischdi @k8s-ci-robot @sbueringer