Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.7] 🐛 Delete out of date machines with unhealthy control plane component conditions when rolling out KCP #10421

Merged
merged 14 commits into from
Apr 11, 2024
Merged

[release-1.7] 🐛 Delete out of date machines with unhealthy control plane component conditions when rolling out KCP #10421

merged 14 commits into from
Apr 11, 2024

Conversation

k8s-infra-cherrypick-robot
Copy link

This is an automated cherry-pick of #10196

/assign sbueringer

Levi080513 and others added 14 commits April 11, 2024 11:51
@Levi080513
Prioritize deletion of abnormal outdated CP machines when scaling dow…
c5881e2 
…n KCP
@Levi080513 @neolit123
Apply suggestions from code review
1f06b73 
Co-authored-by: Lubomir I. Ivanov <[email protected]>
@jessehu
refine function comments and test code
876e95c
@jessehu
address review comments and refine doc
13b6eed
@Levi080513
address review comments
2164685
@Levi080513
fix imperfect check conditions and update ut
63c0281
@Levi080513
add note
6730c10
@Levi080513
redefine func name
5b1e9c8
@jessehu @sbueringer
Update docs/proposals/20191017-kubeadm-based-control-plane.md
1ad1a86 
Co-authored-by: Stefan Büringer <[email protected]>
@jessehu @sbueringer
Update util/collections/machine_filters.go
0227b82 
Co-authored-by: Stefan Büringer <[email protected]>
@jessehu
rename func to UnhealthyMachinesWithMissingNodeOrUnhealthyControlPlan…
26d08b1 
…eComponents
@jessehu
nil machine returns false
fb628c0
@jessehu
rename func HealthyMachinesByHealthCheck to HealthyMachinesByMachineH…
b3a54b9 
…ealthCheck
@jessehu
Remove !HasNode()(machine) condition from unhealthy machine filter
b892ae1
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Apr 11, 2024
Merged
@k8s-ci-robot k8s-ci-robot added this to the v1.7 milestone Apr 11, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label labels Apr 11, 2024
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 11, 2024
@sbueringer sbueringer added tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. area/provider/control-plane-kubeadm Issues or PRs related to KCP labels Apr 11, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-area PR is missing an area label label Apr 11, 2024
@sbueringer
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 11, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 6bf8ad2717c450358962162a3979d2df19e17d3e

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 11, 2024
@k8s-ci-robot k8s-ci-robot merged commit 9c9191e into kubernetes-sigs:release-1.7 Apr 11, 2024
25 checks passed
@sbueringer sbueringer mentioned this pull request Apr 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enxebre enxebre Awaiting requested review from enxebre

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

Assignees

@sbueringer sbueringer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/control-plane-kubeadm Issues or PRs related to KCP cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@k8s-infra-cherrypick-robot @sbueringer @k8s-ci-robot @Levi080513 @jessehu