馃悰 Add wait for MachineList to be available #10301
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
do-not-merge/needs-area
|
/area e2e-testing |
k8s-ci-robot
added
area/e2e-testing
test/e2e/clusterctl_upgrade.go
Outdated
| @@ -548,6 +548,24 @@ func ClusterctlUpgradeSpec(ctx context.Context, inputGetter func() ClusterctlUpg | |||
| input.PostUpgrade(managementClusterProxy, workloadClusterNamespace, managementClusterName) | |||
| } | |||
|
|
|||
| // After the upgrade check that MachineList is available. | |||
There was a problem hiding this comment.
Could we add a comment about what problem we're solving here.
| // After the upgrade check that MachineList is available. | |
| // After the upgrade check that MachineList is available. This ensures the APIServer is serving without error before checking that it `Consistently` returns the MachineList later on. |
Signed-off-by: muhammad adil ghaffar <[email protected]>
adilGhaffarDev
force-pushed
the
clusterctl-flake-fix/adil
branch
from
5d0b880
to
882933e
Compare
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: acd1037f4d0c1f4daef9c9887fea232d66febdde
|
|
/test ? |
|
@adilGhaffarDev: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test pull-cluster-api-e2e-main |
|
/test pull-cluster-api-e2e-dualstack-and-ipv6-main |
|
/test pull-cluster-api-e2e-main |
1 similar comment
|
/test pull-cluster-api-e2e-main |
|
@sbueringer can we merge this before today's release if it looks ok? |
|
/lgtm Thx for adding this. This makes sense! /assign sbueringer |
|
Yup let's merge it /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):trying to fix the flake mentioned here: #9688 (comment)