馃尡 Add unit tests for MachinePools in topology/scope package #10052
Conversation
k8s-ci-robot
added
area/clusterclass
k8s-ci-robot
added
the
size/XL
willie-yao
force-pushed
the
cc-scope-tests
branch
3 times, most recently
from
6688e74
to
346dbf3
Compare
|
Thank you for the support @willie-yao. Looking forward to learning so much. |
| @@ -155,3 +157,147 @@ func TestUpgrading(t *testing.T) { | |||
| g.Expect(got).To(BeComparableTo(want)) | |||
| }) | |||
| } | |||
|
|
|||
| func TestMPIsUpgrading(t *testing.T) { | |||
There was a problem hiding this comment.
Sorry didn't get around to review your PRs yet (and I'm soon on PTO).
Just fyi for now. This will be also added in this PR (and moved around): https://github.com/kubernetes-sigs/cluster-api/pull/10063/files
There was a problem hiding this comment.
No problem, thanks for letting me know!!
There was a problem hiding this comment.
k8s-ci-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
willie-yao
force-pushed
the
cc-scope-tests
branch
from
346dbf3
to
6685ddd
Compare
k8s-ci-robot
removed
the
needs-rebase
willie-yao
force-pushed
the
cc-scope-tests
branch
2 times, most recently
from
8cbfdaa
to
9541409
Compare
|
@sbueringer @chrischdi I updated the PR to account for the moved test, PTAL! |
Co-authored-by: razashahid107 <[email protected]>
willie-yao
force-pushed
the
cc-scope-tests
branch
from
9541409
to
c497c58
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: fc196e8301d175db4fd0911b8e8e6aa169c797b9
|
|
Thanks for adding those tests! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
What this PR does / why we need it:
This PR adds unit tests for MachinePool workers in ClusterClass for the following files:
Big thanks to @razashahid107 for most of the work in
state_test.go! 馃殌Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes part of #10028
/area clusterclass