Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update kustomize docs for patches and openapi #131

Merged

Conversation

natasha41575
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 5, 2021
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 5, 2021
@natasha41575
Copy link
Contributor Author

/cc @monopole
/cc @Shell32-Natsu

@natasha41575
Copy link
Contributor Author

/assign @pwittrock

@SyamSundarKirubakaran
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 17, 2021
@natasha41575
Copy link
Contributor Author

natasha41575 commented Apr 19, 2021

@SyamSundarKirubakaran the CI check appears unrelated to my change (it's failing for many open PRs, not just this one). What's going on there? Is it still possible to merge this PR?

@SyamSundarKirubakaran
Copy link
Contributor

@natasha41575 seems like we are using a linter - https://github.com/alecthomas/gometalinter in the CI process which got deprecated. so go get on pre-scripts are failing.

@pwittrock can you suggest.

@pwittrock
Copy link
Contributor

@KnVerey

@KnVerey
Copy link
Contributor

KnVerey commented Apr 22, 2021

It looks like we need to switch this repo over to golangci-lint, and that that's actually partway done already. The repo has both a travis.yml (correct) and a travis.yaml (probably ignored?), where the former installs the deprecated linter and the latter would install the new one. The actual linter script appears to use the new one, though it also attempts to install the old one again. There's an open issue here: #120

@natasha41575
Copy link
Contributor Author

@KnVerey is anyone working on the issue?

@natasha41575
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 28, 2021
Copy link
Contributor

@monopole monopole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 28, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: monopole, natasha41575, SyamSundarKirubakaran

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [SyamSundarKirubakaran]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants